fix: replace methods imports everywhere (#130)

pillarjs · Oct 29, 2024 · 0fe592e · 0fe592e
1 parent 878b0e0
commit 0fe592e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -14,7 +14,7 @@
 
 const isPromise = require('is-promise')
 const Layer = require('./lib/layer')
-const methods = require('methods')
+const { METHODS } = require('node:http')
 const mixin = require('utils-merge')
 const parseUrl = require('parseurl')
 const Route = require('./lib/route')
@@ -26,6 +26,7 @@ const Route = require('./lib/route')
 
 const slice = Array.prototype.slice
 const flatten = Array.prototype.flat
+const methods = METHODS.map((method) => method.toLowerCase())
 
 /**
  * Expose `Router`.

diff --git a/lib/route.js b/lib/route.js
@@ -22,6 +22,7 @@ const { METHODS } = require('node:http')
 
 const slice = Array.prototype.slice
 const flatten = Array.prototype.flat
+const methods = METHODS.map((method) => method.toLowerCase())
 
 /* istanbul ignore next */
 const defer = typeof setImmediate === 'function'
@@ -215,9 +216,6 @@ Route.prototype.all = function all (handler) {
   return this
 }
 
-
-const methods = METHODS.map((method) => method.toLowerCase())
-
 methods.forEach(function (method) {
   Route.prototype[method] = function (handler) {
     const callbacks = flatten.call(slice.call(arguments), Infinity)

diff --git a/test/route.js b/test/route.js
@@ -1,6 +1,5 @@
 const { it, describe } = require('mocha')
 const Buffer = require('safe-buffer').Buffer
-const methods = require('methods')
 const series = require('run-series')
 const Router = require('..')
 const utils = require('./support/utils')
@@ -13,6 +12,7 @@ const shouldHaveBody = utils.shouldHaveBody
 const shouldHitHandle = utils.shouldHitHandle
 const shouldNotHaveBody = utils.shouldNotHaveBody
 const shouldNotHitHandle = utils.shouldNotHitHandle
+const methods = utils.methods
 
 const describePromises = global.Promise ? describe : describe.skip
 

diff --git a/test/router.js b/test/router.js
@@ -1,7 +1,6 @@
 const { it, describe } = require('mocha')
 const series = require('run-series')
 const Buffer = require('safe-buffer').Buffer
-const methods = require('methods')
 const Router = require('..')
 const utils = require('./support/utils')
 
@@ -14,6 +13,7 @@ const shouldHaveBody = utils.shouldHaveBody
 const shouldHitHandle = utils.shouldHitHandle
 const shouldNotHaveBody = utils.shouldNotHaveBody
 const shouldNotHitHandle = utils.shouldNotHitHandle
+const methods = utils.methods
 
 const describePromises = global.Promise ? describe : describe.skip
 

diff --git a/test/support/utils.js b/test/support/utils.js
@@ -2,9 +2,11 @@ const assert = require('assert')
 const Buffer = require('safe-buffer').Buffer
 const finalhandler = require('finalhandler')
 const http = require('http')
-const methods = require('methods')
+const { METHODS } = require('node:http')
 const request = require('supertest')
 
+const methods = METHODS.map((method) => method.toLowerCase())
+
 exports.assert = assert
 exports.createHitHandle = createHitHandle
 exports.createServer = createServer
@@ -14,6 +16,7 @@ exports.shouldHaveBody = shouldHaveBody
 exports.shouldNotHaveBody = shouldNotHaveBody
 exports.shouldHitHandle = shouldHitHandle
 exports.shouldNotHitHandle = shouldNotHitHandle
+exports.methods = methods
 
 function createHitHandle (num) {
   const name = 'x-fn-' + String(num)