From 391f1a17e5697bf1fd9d57fa1b2a482aeab1b1a0 Mon Sep 17 00:00:00 2001
From: Katashin <ktsn55@gmail.com>
Date: Mon, 17 Feb 2020 10:07:54 +0100
Subject: [PATCH] fix: avoid accessing undeclared instance fields on type level
 (#189)

* fix: avoid accessing undeclared instance fields on type level

* fix: inherit vue constructor type for constructor proxy

fix #187
fix #185
---
 src/component/component.ts         | 10 +++++-----
 test/types/createComponent.spec.ts |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/component/component.ts b/src/component/component.ts
index 71148d52..e9b36b6a 100644
--- a/src/component/component.ts
+++ b/src/component/component.ts
@@ -22,8 +22,8 @@ export type ComponentRenderProxy<P = {}, S = {}, PublicProps = P> = {
   S;
 
 // for Vetur and TSX support
-type VueConstructorProxy<PropsOptions, RawBindings> = {
-  new (): ComponentRenderProxy<
+type VueConstructorProxy<PropsOptions, RawBindings> = VueConstructor & {
+  new (...args: any[]): ComponentRenderProxy<
     ExtractPropTypes<PropsOptions>,
     UnwrapRef<RawBindings>,
     ExtractPropTypes<PropsOptions, false>
@@ -65,15 +65,15 @@ interface ComponentOptionsWithProps<
   setup?: SetupFunction<Props, RawBindings>;
 }
 
-interface ComponentOptionsWithoutProps<Props = never, RawBindings = Data> {
+interface ComponentOptionsWithoutProps<Props = unknown, RawBindings = Data> {
   props?: undefined;
   setup?: SetupFunction<Props, RawBindings>;
 }
 
 // overload 1: object format with no props
 export function createComponent<RawBindings>(
-  options: ComponentOptionsWithoutProps<never, RawBindings>
-): VueProxy<never, RawBindings>;
+  options: ComponentOptionsWithoutProps<unknown, RawBindings>
+): VueProxy<unknown, RawBindings>;
 // overload 2: object format with object props declaration
 // see `ExtractPropTypes` in ./componentProps.ts
 export function createComponent<
diff --git a/test/types/createComponent.spec.ts b/test/types/createComponent.spec.ts
index 1a0439bb..c188467d 100644
--- a/test/types/createComponent.spec.ts
+++ b/test/types/createComponent.spec.ts
@@ -89,7 +89,7 @@ describe('createComponent', () => {
     const App = createComponent({
       setup(props, ctx) {
         isTypeEqual<SetupContext, typeof ctx>(true);
-        isTypeEqual<never, typeof props>(true);
+        isTypeEqual<unknown, typeof props>(true);
         return () => null;
       },
     });