Skip to content

Commit d05deb9

Browse files
committed
PBGitRevSpecifier: tweak "isSimpleRef" a bit
For example, HEAD is a simple ref, but "stable..HEAD" isn't.
1 parent 1c3ee96 commit d05deb9

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

PBGitRevSpecifier.m

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,19 @@ + (PBGitRevSpecifier *)localBranchesRevSpec
4747
[revspec setDescription:@"Local branches"];
4848
return revspec;
4949
}
50+
5051
- (BOOL) isSimpleRef
5152
{
52-
return ([parameters count] == 1 && ![[parameters objectAtIndex:0] hasPrefix:@"-"]);
53+
if ([parameters count] > 1)
54+
return NO;
55+
56+
NSString *param = [parameters objectAtIndex:0];
57+
if ([param hasPrefix:@"-"] ||
58+
[param rangeOfCharacterFromSet:[NSCharacterSet characterSetWithCharactersInString:@"^@{}~:"]].location != NSNotFound ||
59+
[param rangeOfString:@".."].location != NSNotFound)
60+
return NO;
61+
62+
return YES;
5363
}
5464

5565
- (NSString*) simpleRef

0 commit comments

Comments
 (0)