Skip to content

Conversation

@thomassimmer
Copy link

Hello,

This PR is for #79

It's my first technical PR ever, I hope I did what's necessary!

Thank you for the library, it's amazing 👍

Cheers,
Thomas

@pierpo
Copy link
Owner

pierpo commented Mar 13, 2024

Hi! Thank you for the contribution, that's awesome 🎉
Looks great. I will have a deeper look in the coming days. Feel free to ping me if I don't come back to you 😁

FYI, this is a breaking change... It's not to be taken lightly ;)
I think I agree with the new API though. This will be a new major release then!

@kluzhnov
Copy link

Hi @pierpo It will be nice to have this PR merged, how community can help you with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants