Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed attribute 'prices_are_incl_tax' for Estimate entity. #252

Open
belatrix22 opened this issue Nov 10, 2021 · 3 comments
Open

Missed attribute 'prices_are_incl_tax' for Estimate entity. #252

belatrix22 opened this issue Nov 10, 2021 · 3 comments

Comments

@belatrix22
Copy link

No description provided.

@belatrix22
Copy link
Author

belatrix22 commented Nov 10, 2021

Hi, I'm using this library for my project. I found that entity Estimate missed attribute prices_are_incl_tax
Can someone add this attribute to this Estimate parameter here:
protected $fillable = [
'id',
'administration_id',
'contact_id',
'contact',
'estimate_id',
'workflow_id',
'document_style_id',
'identity_id',
'draft_id',
'state',
'estimate_date',
'due_date',
'reference',
'language',
'currency',
'exchange_rate',
'discount',
'original_estimate_id',
'show_tax',
'sign_online',
'sent_at',
'accepted_at',
'rejected_at',
'archived_at',
'created_at',
'updated_at',
'public_view_code',
'version',
'pre_text',
'post_text',
'details',
'prices_are_incl_tax',
'total_price_excl_tax',
'total_price_excl_tax_base',
'total_price_incl_tax',
'total_price_incl_tax_base',
'total_discount',
'url',
'custom_fields',
'notes',
'attachments',
'events',
'tax_totals',
];

Or how can I do pull request for this issue.
I tried to create new branch and push it to make pull request but I don't have access rights to do it.

@patrickbrouwers
Copy link
Contributor

I created a PR for it: #253

@arondeparon
Copy link
Contributor

Seems like this issue can be closed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants