WinForms: Show icon when set in Dialog #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for the contribution! Would it make sense to set ShowIcon = false if it was then set to null? (I guess the code would have to be updated to allow a null icon too). |
|
Yeah, we'd need to update WinForms/WPF/GTK to handle nulls. I could do it if you want, but IMO an Icon is generally a set-once-at-construction thing and I don't think there'd be much use for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DialogHandler ShowIcon is set to false:
Eto/src/Eto.WinForms/Forms/DialogHandler.cs
Line 18 in 5fb78c0
If an icon is manually set it should be displayed.
Using an "if" instead of just setting to true to avoid unnecessary redrawing.