Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav item link role="button" is margined negatively #568

Open
suche-cz opened this issue Jun 25, 2024 · 1 comment
Open

Nav item link role="button" is margined negatively #568

suche-cz opened this issue Jun 25, 2024 · 1 comment

Comments

@suche-cz
Copy link

image

margin defined in: _nav.scss 52
nav li :where(a,[role=link])

maybe it should be nav li a:not([role=link]) ?

<nav>
    <ul>
        <li>Hello</li>
        <li><a href="#">Hello</a></li>
        <li><a href="#">Hello</a></li>
        <li><a href="#" role="button">Hello</a></li>
        <li><button>Hello</button></li>
    </ul>
</nav>

@Sector6759
Copy link

Sector6759 commented Jul 5, 2024

I think it would be better to add margin-top: 0; to this rule:

// Minimal support for buttons and forms elements
button,
[role="button"],
[type="button"],
input:not([type="checkbox"], [type="radio"], [type="range"], [type="file"]),
select {
height: auto;
margin-right: inherit;
margin-bottom: 0;
margin-left: inherit;
padding: calc(
var(#{$css-var-prefix}nav-link-spacing-vertical) -
(var(#{$css-var-prefix}border-width) * 2)
)
var(#{$css-var-prefix}nav-link-spacing-horizontal);
}

BTW this is a duplicate of #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants