Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean and pin test requirements #376

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Clean and pin test requirements #376

merged 1 commit into from
Feb 16, 2022

Conversation

MartinHjelmare
Copy link
Contributor

@MartinHjelmare MartinHjelmare commented Feb 16, 2022 •
edited
Loading

Breaking change

Proposed change

  • Pin all test requirements to exact versions. Test requirements should be pinned strictly to avoid unintentional breakage.
  • Remove mock requirement which is a backport and now part of standard library since Python 3.3.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:



Additional information



    

  • This PR fixes or closes issue: fixes #
    • 

  • This PR is related to issue:
    • 



Checklist



    

  •  The code change is tested and works locally.
    • 

  •  Local tests pass. Your PR cannot be merged unless tests pass
    • 

  •  There is no commented out code in this PR.
    • 

  •  Tests have been added to verify that the new code works.
    • 



If user exposed functionality or configuration variables are added/changed:


    

  •  Documentation added/updated to README
    • 


    

  
  



      


          

          
  

    
  
    
    

  

  




          

        
      




  





        

       
            



      

  
        





      

  
        





      

  
          

  

    
  

  



        @balloob
  balloob



        merged commit c0e4ecf
      into

      
  
    picklepete:master
  


    Feb 16, 2022

  







  

  
  

  
      @MartinHjelmare
  MartinHjelmare


    
    deleted the
    
      
        clean-test-requirements
    
    branch

    
      February 16, 2022 20:46
    
    













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
    @balloob
  
    balloob



          
            
              
            
          
          balloob approved these changes

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




        
      

    

  
      

  

    

      2 participants
    

    

        
          @MartinHjelmare 
        
          @balloob