Fix for 450 reauthentication failure bug #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcobb321
changed the title
balloob
reviewed
Feb 16, 2022
pyicloud/base.py
Outdated
| @@ -112,7 +112,10 @@ def request(self, method, url, **kwargs): # pylint: disable=arguments-differ | |||
| # Handle re-authentication for Find My iPhone | |||
| LOGGER.debug("Re-authenticating Find My iPhone service") | |||
| try: | |||
| self.service.authenticate(True, "find") | |||
| # If 450, authentication requires a full sign in to the account | |||
| service = None if response.status_code == 450 else 'find' | |||
There was a problem hiding this comment.
It's always status code 450 here because that's checked in the above if-statement
There was a problem hiding this comment.
The check for a response.code 450 should actually include a check for the other response codes also requiring a reauthentication (421 & 500), not just a 450. Updated PR submitted.
balloob
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: