Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update click version to reduce potential for dependency conflict #360

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

mchonofsky
Copy link
Contributor

@mchonofsky mchonofsky commented Dec 19, 2021

Proposed change

The stringent dependency on click (>=6.1, <=7.0 I think) causes conflicts with other packages. I have

  • checked the click change log to check that the functionality in pyicloud is not affected by this change;
  • run the tests with click 8.0.3, which pass;
  • updated requirements.txt to change the required version of click.

(Fixes #289)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works. There is no new code

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README not applicable

@nesyuk
Copy link

nesyuk commented Feb 10, 2022

Hi! Is there a chance that this PR is going to be merged soon? I'm having a dependency problem as well.

requirements.txt Outdated Show resolved Hide resolved
@balloob balloob merged commit 0f0f3e0 into picklepete:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement is pinned for pyicloud 0.9.7: click>=6.0,<=7.1.1
3 participants