Drive cache #296
Open
Drive cache #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cachetools to the requirements list. Drive-By: Remove upper version limit for click, keyring and keyring.alt. Fixes: picklepete#289 Fixes: picklepete#290
This is part one of a two part commit. This part removes the existing permanent cache for folder content and always fetch fresh data and return that. The second part will add a real TTL'd cache.
Allow for a TTL expiry cache in Drive. Cache is active by default, but can be changed on demand. Add debug logging.
Allow specific functions to invalidate the cache if needed. Makes sense after e.g. mkdir or an upload.
|
Hmm. Looks like cachetools does not exist for Python <3.5... There's also a complain about me accessing _cache from outside the DriveService object... That is true, but I kinda feel it's acceptable to use the service-wide cache from the DriveNode object... But it is still a drive-internal cache which is why I'm prefixing it with an underscore. |
|
Will remove support <3.6 or even <3.7 Coming to this PR just after this removal. |
|
Needs #303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Drive by default caches directory entries and will only invalidate them if a new directory is fetched.
This caching is happening in get_children().
Rework the cache to use a real TTL cache using the external cachetools.
Drive-By: Remove upper limits of dependency versions for click and keychain.
Fixes: #289
Fixes: #290
Type of change
Checklist
If user exposed functionality or configuration variables are added/changed: