Skip to content

Feature: transfer label descriptions #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Conversation

alystair
Copy link
Contributor

@alystair alystair commented Oct 16, 2022

  • Now when labels are transferred, their descriptions are as well!
  • Added some color options for your console output, feel free to use elsewhere :)
  • trimOversizedLabelDescriptions boolean option to trim them to the maximum allowable length instead of leaving blank, maybe a bit excessive feel free to remove this logic.

image

Now when labels are transferred, their descriptions are as well!
@alystair
Copy link
Contributor Author

alystair commented Oct 16, 2022

Note the only major potential edge case I haven't accounted for is if there is a difference between maximum description length between the two - never bothered checking. Assuming the worst - If anyone ever complains you can just trim the description length and output a warning/notice to CLI ¯\_(ツ)_/¯

Edit: There was, see below. Fixed :)

@alystair
Copy link
Contributor Author

alystair commented Oct 16, 2022

Hrm, actually looking at it now - it seems some label creations are failing silently

@alystair
Copy link
Contributor Author

LOL it's failing for the exact edge case I predicted - the label description length on GitHub is much shorter.

@alystair
Copy link
Contributor Author

Ok this is in a great place now, I added a trimOversizedLabelDescriptions boolean setting, when false (default) oversized descriptions are excluded, otherwise they are trimmed to 100 characters. Either way a warning is shown.

image

Oh yeah, I also added some static color consts - so you can throw those into your various console notices to spruce up the coloring to make it easier to see issues :)

@alystair
Copy link
Contributor Author

Getting a crash, not ready yet... failing on emojis in description.... guh.
image

@alystair
Copy link
Contributor Author

OK, all fixed up and ready to go! 👍

@spruce
Copy link
Member

spruce commented Mar 15, 2023

Thanks :)

@spruce spruce merged commit a5d25ea into piceaTech:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants