Feature Request: Exceptions when Subplot Matrix is Bigger then Default

[soraxas]

I was confused by a strange index out of bound error

  File "xxxxx/terminal-plot/lib/python3.9/site-packages/plotext/_figure.py", line 55, in set_subplot
    self.subplot = self.subplots[self.row][self.col]
IndexError: list index out of range

which, after some extensive investigation I realise it's due to

plotext/plotext/_figure.py

Line 41 in db4bb95

rows = rows if rows < self.default.rows_max else self.default.rows_max

and the defaults is defined in

plotext/plotext/_default.py

Line 6 in db4bb95

self.cols_max = 10 # max number of subplots columns and rows

---

I don't oppose sane defaults (it should probably be configurable). However, this override is undetectable from user code as it is enforced in figure creation without any notice. In my opinion, it might be better off throw an exception instead of silently overrides the subplot size...

[piccolomo]

Hi @soraxas, thanks for the report and sorry for late reply (I put aside this project for awhile after the latest version update).

I understand the issue: It seems it requires the creation of custom exceptions, which I am not familiar with yet, therefore I will work on it for next version.

Also I like the idea of giving the user the ability to configure default values, something i will also think about.

I will update and thanks

[piccolomo]

Hi @soraxas ,

thanks a lot for the issue report. I should have sorted this in the newly updated 4.1.0 version, available on github and pypi.

Now setting a higher then 10 number of rows or cols should throw and exception.

Also in order to change the default value max value of 10, it is probably easier to do it directly instead of creating a function. Here is how:

plt.figure.default.rows_max = 13
plt.figure.default.cols_max = 20

Please let me know what you think, especially if the issue persists in any other form.

All the best,
Savino.

[soraxas]

Thanks for the kind reply and update on matter, appreciate it! Thanks for the amazing work