Skip to content

Conversation

@abhishek-compro
Copy link

Fixes #467

@abhishek-compro
Copy link
Author

@dantownsend I have added bit extra styling. Let me know your thoughts. The border radius isn't consistently applied to all places though.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (1157c12) to head (914c674).
⚠️ Report is 50 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   93.42%   94.04%   +0.62%     
==========================================
  Files           5        5              
  Lines         365      403      +38     
==========================================
+ Hits          341      379      +38     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dantownsend dantownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍

background-color: rgba(0, 0, 0, 0.1);
overflow-y: auto;
height: 100%;
height: calc(100vh - 5rem);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 5rem the approx height of the top nav bar?

Copy link
Author

@abhishek-compro abhishek-compro Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a rounded off value and enough to not put a global scroll bar. The only thing is that there is a slight footer padding which is both a good and bad thing depending on how you see it.

@abhishek-compro
Copy link
Author

abhishek-compro commented Dec 22, 2025

@dantownsend @sinisaos

  1. Have fixed horizontal scroll as well (previously scrolling horizontally would move action buttons out of sight / screen)
  2. Now buttons (including buttons using anchor tags) have consistent hover and active effects. Have removed the scale transform and am relying mostly on background color change on hover.
  3. The close button on filters page is now red in color

Let me know if you need any modifications.

@sinisaos
Copy link
Member

@abhishek-compro That looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow independent scrolling of sidebar, filter and main content sections

4 participants