-
Notifications
You must be signed in to change notification settings - Fork 45
Allow independent scrolling of nav, filter and main sections #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow independent scrolling of nav, filter and main sections #470
Conversation
|
@dantownsend I have added bit extra styling. Let me know your thoughts. The border radius isn't consistently applied to all places though. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 93.42% 94.04% +0.62%
==========================================
Files 5 5
Lines 365 403 +38
==========================================
+ Hits 341 379 +38
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dantownsend
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 👍
| background-color: rgba(0, 0, 0, 0.1); | ||
| overflow-y: auto; | ||
| height: 100%; | ||
| height: calc(100vh - 5rem); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 5rem the approx height of the top nav bar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a rounded off value and enough to not put a global scroll bar. The only thing is that there is a slight footer padding which is both a good and bad thing depending on how you see it.
Let me know if you need any modifications. |
|
@abhishek-compro That looks good to me 👍 |
Fixes #467