Skip to content

Commit bd81adb

Browse files
committed
Unskip test
1 parent 53e38c8 commit bd81adb

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

tests/test_ptdm.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from unittest import TestCase, skip
1+
from unittest import TestCase
22
from unittest.mock import Mock, patch
33

44
from tests.utils import wait_until
@@ -8,31 +8,34 @@ class PTDMSubscribeClientTestCase(TestCase):
88
def setUp(self):
99
self.zmq_patch = patch("pitop.common.ptdm.zmq")
1010
self.zmq_mock = self.zmq_patch.start()
11+
self.poller_mock = Mock()
1112
self.context_mock = Mock()
1213
self.socket_mock = Mock()
1314

1415
self.socket_mock.recv_string.return_value = ""
1516
self.context_mock.socket.return_value = self.socket_mock
1617
self.zmq_mock.Context.return_value = self.context_mock
18+
self.zmq_mock.Poller.return_value = self.poller_mock
19+
self.poller_mock.poll.return_value = []
1720
self.addCleanup(self.zmq_patch.stop)
1821

19-
@skip
2022
def test_callback_called_when_message_is_published(self):
2123
from pitop.common.ptdm import Message, PTDMSubscribeClient
2224

25+
self.poller_mock.poll.return_value = [1]
2326
self.socket_mock.recv_string.return_value = f"{Message.PUB_LOW_BATTERY_WARNING}"
2427

25-
callback = Mock()
28+
def callback():
29+
callback.counter += 1
2630

27-
client = PTDMSubscribeClient()
28-
client.initialise(
29-
{
30-
Message.PUB_LOW_BATTERY_WARNING: callback,
31-
}
32-
)
31+
callback.counter = 0
3332

33+
client = PTDMSubscribeClient()
34+
client.initialise({Message.PUB_LOW_BATTERY_WARNING: callback})
3435
client.start_listening()
35-
wait_until(lambda: callback.call_count == 1, timeout=3)
36+
37+
wait_until(lambda: callback.counter > 0, timeout=3)
38+
3639
client.stop_listening()
3740

3841
def test_callback_not_included_if_has_wrong_signature(self):

0 commit comments

Comments
 (0)