Skip to content

Add workflows #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: mkdocs
Choose a base branch
from
Open

Add workflows #52

wants to merge 3 commits into from

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Apr 24, 2024

Closes #51

Adds workflows

Proposed Changes

Questions for reviewers

  1. Should we add a Contributors section in the README like our other repos? I think yes!
  2. This is still a draft because I am wondering about the default branch being mkdocs - does any workflow code need to change (content/location) to reflect that?

Change Type

  • bugfix
  • refactoring
  • infrastructure
  • documentation
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@RayStick RayStick added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Apr 24, 2024
@RayStick RayStick requested a review from smoia April 24, 2024 15:28
@RayStick RayStick self-assigned this Apr 24, 2024
@RayStick RayStick changed the title Add auto-author and auto-label to github workflow Add workflows and update README Jul 9, 2025
@RayStick RayStick changed the title Add workflows and update README Add workflows Jul 9, 2025
![Thank You Banner](https://raw.githubusercontent.com/physiopy/physiopy-test-workflows/master/welcome_banner.png)
🎉 Congrats on merging your first pull request in this repo! We appreciate your contribution to the Physiopy community!
:eyes: Please check that your contribution is correctly reported in the repo's README and on Physiopy's website!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the hyperlink to the Physiopy website home page ?
https://physiopy.github.io/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see add link

@m-miedema m-miedema self-requested a review July 14, 2025 21:25
@m-miedema m-miedema marked this pull request as ready for review July 14, 2025 21:25
Copy link
Member

@m-miedema m-miedema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: mkdocs, I'm not sure that that would change anything - maybe the simplest thing is to assume it won't and then test it? It's good to know since I imagine this might also have implications for the Community Practices repo!

I do think it's good to have a contributors readme but was wondering about the directive to check that contributions are accurately reflected on the website. Is the website page one that gets manually updated every so often? I wouldn't want someone to expect to see changes reflected there instantaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement auto-author-assign and auto-label workflows
3 participants