Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library is not compatible with java modules #84

Closed
ertong opened this issue Apr 5, 2021 · 4 comments
Closed

Library is not compatible with java modules #84

ertong opened this issue Apr 5, 2021 · 4 comments

Comments

@ertong
Copy link

ertong commented Apr 5, 2021

There is no module-info.java in argon2-jvm-nolibs package.
Moreover
Automatic-Module-Name: de.mkammerer.argon2-nolibs
which is invalid package name.

As a result, in order to use the library as module it should be repackaged, which is not the best thing to do.

@phxql
Copy link
Owner

phxql commented Apr 6, 2021

This is fixed in #80 which lands in the next release.

@phxql phxql closed this as completed Apr 6, 2021
@phxql
Copy link
Owner

phxql commented Apr 6, 2021

Fix is released in >= 2.10.

@A248
Copy link
Contributor

A248 commented Apr 6, 2021

@phxql Would it be acceptable to PR a multi-release jar which includes module-info in META-INF/versions/11? There are still some benefits to having a full module descriptor (module-info.java) over Automatic-Module-Name. Creating a MRJAR would require building with JDK 11, but runtime compatibility with JDK 6 can still be maintained.

@phxql
Copy link
Owner

phxql commented Apr 7, 2021

Yes, if you want to help to support JPMS for real, i'll be thankful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants