Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide the site key from the embed js #2

Open
lgp171188 opened this issue Apr 2, 2012 · 3 comments
Open

Ability to hide the site key from the embed js #2

lgp171188 opened this issue Apr 2, 2012 · 3 comments

Comments

@lgp171188
Copy link

The site key is visible explicitly in the embed js and hence can be used/abused by others having no relation to the site. So there must be some way to hide the key

@codykrieger
Copy link

That's a pretty common paradigm for JavaScript embeds - comment systems, analytics, Twitter and Facebook widgets, etc. all do the same thing. Disqus gets around this by allowing you to specify a whitelist of domains that are allowed to post comments, which Juvia could easily do as well (submit a pull request!). Basically unless you want to write a Juvia proxy that you control, and handle all of the Juvia API stuff server-side, yeah, your key is going to be visible in the embed JavaScript.

@FooBarWidget
Copy link
Member

What codykrieger said. We have to expose some identifier for this to work. So yeah, it can be abused in the form of having the comments embeddable on another site, but why exactly do you worry about it? Even if you build a whitelist system, if an attacker really wants to screw you he can just write a proxy talks to your server.

@lgp171188
Copy link
Author

Is it possible to set and use a same domain/subdomain origin policy? I've heard about these words somewhere, not sure if they are relevant and applicable here, so just asking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants