Add regression test

Author: herndlm

phpstan-baseline.neon

@@ -9,3 +9,8 @@ parameters:
 			message: "#^Accessing PHPStan\\\\Rules\\\\Comparison\\\\ImpossibleCheckTypeStaticMethodCallRule\\:\\:class is not covered by backward compatibility promise\\. The class might change in a minor PHPStan version\\.$#"
 			count: 1
 			path: tests/Type/WebMozartAssert/ImpossibleCheckTypeMethodCallRuleTest.php
+
+		-
+			message: "#^Accessing PHPStan\\\\Rules\\\\Methods\\\\ReturnTypeRule\\:\\:class is not covered by backward compatibility promise\\. The class might change in a minor PHPStan version\\.$#"
+			count: 1
+			path: tests/Type/WebMozartAssert/MethodReturnTypeRuleTest.php

tests/Type/WebMozartAssert/AssertTypeSpecifyingExtensionTest.php

@@ -20,6 +20,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/type.php');
 
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-18.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-117.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-150.php');
 	}
 

tests/Type/WebMozartAssert/MethodReturnTypeRuleTest.php

@@ -0,0 +1,23 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\WebMozartAssert;
+
+use PHPStan\Rules\Methods\ReturnTypeRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/** @extends RuleTestCase<ReturnTypeRule> */
+class MethodReturnTypeRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return self::getContainer()->getByType(ReturnTypeRule::class);
+	}
+
+	public function testBug117(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-117.php'], []);
+	}
+
+}

tests/Type/WebMozartAssert/data/bug-117.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WebmozartAssertBug117;
+
+use Webmozart\Assert\Assert;
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+	/**
+	 * @param mixed[] $requestData
+	 *
+	 * @return array{
+	 *     accountId: int,
+	 *     errorColor: string|null,
+	 *     theme: array{
+	 *         backgroundColor: string|null,
+	 *         textColor: string|null,
+	 *         headerImage: array{id: int}|null,
+	 *     },
+	 * }
+	 */
+	public function getData(int $accountId, array $requestData): array
+	{
+		Assert::keyExists($requestData, 'errorColor');
+		Assert::nullOrString($requestData['errorColor']);
+
+		Assert::keyExists($requestData, 'theme');
+		Assert::isArray($requestData['theme']);
+
+		Assert::keyExists($requestData['theme'], 'headerImage');
+		Assert::nullOrIsArray($requestData['theme']['headerImage']);
+
+		if (null !== $requestData['theme']['headerImage']) {
+			Assert::keyExists($requestData['theme']['headerImage'], 'id');
+			Assert::integer($requestData['theme']['headerImage']['id']);
+		}
+
+		Assert::keyExists($requestData, 'theme', 'backgroundColor');
+		Assert::nullOrString($requestData['theme']['backgroundColor']);
+
+		Assert::keyExists($requestData, 'theme', 'textColor');
+		Assert::nullOrString($requestData['theme']['textColor']);
+
+		$requestData['accountId'] = $accountId;
+
+		assertType("hasOffsetValue('accountId', int)&hasOffsetValue('errorColor', string|null)&hasOffsetValue('theme', array&hasOffsetValue('backgroundColor', string|null)&hasOffsetValue('headerImage', (array&hasOffsetValue('id', int))|null)&hasOffsetValue('textColor', string|null))&non-empty-array", $requestData);
+
+		return $requestData;
+	}
+}