Skip to content

remove case sensitivity from service ids #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stefanotorresi
Copy link

fixes #9

@lookyman
Copy link
Collaborator

lookyman commented Apr 2, 2019

What version of Symfony are you using?

@lookyman
Copy link
Collaborator

closing, see #9 (comment)

@lookyman lookyman closed this Apr 16, 2019
@stefanotorresi
Copy link
Author

stefanotorresi commented Apr 16, 2019

that's too bad: I think the issue is not in the upstream, because service definitions are NOT case sensitive. It just happens that newer version of Symfony generate the xml manifest with the original case instead of applying strtolower. This library should NOT treat service names as case sensitive.

@lookyman
Copy link
Collaborator

Ok, I'll reconsider it...

@lookyman lookyman reopened this Apr 16, 2019
@jvasseur
Copy link
Contributor

jvasseur commented Apr 16, 2019

because service definitions are NOT case sensitive.

That's false, services id are case sensitive since Symfony 4.

@stefanotorresi
Copy link
Author

That's false, services id are case sensitive since Symfony 4.

I see. That's not the case for Symfony 3, still.

@stefanotorresi
Copy link
Author

stefanotorresi commented Apr 16, 2019

I guess I'm gonna have to give up on this, as it's not forward compatible with SF4 and granting compatibility with both 3 and 4 is out of the scope of my original intent.
There is ground to build a use case for a separate check about this, since class names are not case sensitive and they are commonly used as service ids; see this discussion.
Thanks for your input, @jvasseur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services should not be case sensitive
3 participants