Simplify tests in which checkNullables is always true

staabm · ondrejmirtes · commit e8616380171e · 2025-09-01T17:58:43.000+02:00
diff --git a/tests/Rules/Functions/ArrayFilterStrictRuleTest.php b/tests/Rules/Functions/ArrayFilterStrictRuleTest.php
@@ -11,21 +11,18 @@
 class ArrayFilterStrictRuleTest extends RuleTestCase
 {
 
-	private bool $checkNullables;
-
 	protected function getRule(): Rule
 	{
 		return new ArrayFilterStrictRule(
 			$this->createReflectionProvider(),
 			$this->shouldTreatPhpDocTypesAsCertain(),
-			$this->checkNullables,
+			true,
 			true,
 		);
 	}
 
 	public function testRule(): void
 	{
-		$this->checkNullables = true;
 		$this->analyse([__DIR__ . '/data/array-filter-strict.php'], [
 			[
 				'Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.',
@@ -52,7 +49,6 @@ public function testRule(): void
 
 	public function testRuleAllowMissingCallbackInSomeCases(): void
 	{
-		$this->checkNullables = true;
 		$this->analyse([__DIR__ . '/data/array-filter-allow.php'], [
 			[
 				'Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.',

Original file line number	Diff line number	Diff line change
`@@ -11,21 +11,18 @@`
`11`	`11`	`class ArrayFilterStrictRuleTest extends RuleTestCase`
`12`	`12`	`{`
`13`	`13`
`14`		`- private bool $checkNullables;`
`15`		`-`
`16`	`14`	`protected function getRule(): Rule`
`17`	`15`	`{`
`18`	`16`	`return new ArrayFilterStrictRule(`
`19`	`17`	`$this->createReflectionProvider(),`
`20`	`18`	`$this->shouldTreatPhpDocTypesAsCertain(),`
`21`		`- $this->checkNullables,`
	`19`	`+ true,`
`22`	`20`	`true,`
`23`	`21`	`);`
`24`	`22`	`}`
`25`	`23`
`26`	`24`	`public function testRule(): void`
`27`	`25`	`{`
`28`		`- $this->checkNullables = true;`
`29`	`26`	`$this->analyse([__DIR__ . '/data/array-filter-strict.php'], [`
`30`	`27`	`[`
`31`	`28`	`'Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.',`
`@@ -52,7 +49,6 @@ public function testRule(): void`
`52`	`49`
`53`	`50`	`public function testRuleAllowMissingCallbackInSomeCases(): void`
`54`	`51`	`{`
`55`		`- $this->checkNullables = true;`
`56`	`52`	`$this->analyse([__DIR__ . '/data/array-filter-allow.php'], [`
`57`	`53`	`[`
`58`	`54`	`'Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.',`