Skip to content

micro: use spl_object_id() #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2023
Merged

micro: use spl_object_id() #2592

merged 1 commit into from
Aug 29, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 28, 2023

spl_object_id() exists since php 7.2, I think we can use it over spl_object_id().

rector and wordpress micro benchmarks suggests its faster

@ondrejmirtes ondrejmirtes merged commit bdb141d into phpstan:1.10.x Aug 29, 2023
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the spl branch August 29, 2023 08:01
@samsonasik samsonasik mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staabm @ondrejmirtes @samsonasik