NodeScopeResolver analysed files not as global state and optional #2122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ondrejmirtes We discussed this on our friday call. I prepared PR that would make NodeScopeResolver usable for our use case of collecting latte templates context.
analysedFiles
are not global state anymore but passed as optional parameter toresolveNodes
andresolveStmtNodes
NodeScopeResolver
will not limit what traits it resolvesI split
resolveStmtNodes
to publicresolveStmtNodes
which can setanalysedFiles
and privateiterateStmtNodes
used internally inNodeScopeResolver
to avoid resetinganalysedFiles
or passing it arround all private methods ofNodeScopeResolver