Improve type inference for $object::class === static::class #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Sep 26, 2022
src/Analyser/TypeSpecifier.php
Outdated
Comment on lines
367
to
386
| if ( | ||
| $expr->left instanceof FuncCall | ||
| && $expr->left->name instanceof Name | ||
| && strtolower($expr->left->name->toString()) === 'get_class' | ||
| && isset($expr->left->getArgs()[0]) | ||
| && $rightType instanceof ConstantStringType | ||
| ) { | ||
| return $this->specifyTypesInCondition( | ||
| $scope, | ||
| new Instanceof_( | ||
| $expr->left->getArgs()[0]->value, | ||
| new Name($rightType->getValue()), | ||
| ), | ||
| $context, | ||
| $rootExpr, | ||
| ); | ||
| } |
rvanvelzen
force-pushed
the
static-class-const-equals
branch
from
5d4fc09 to
5154e11
Compare
staabm
reviewed
Sep 26, 2022
| @@ -347,6 +348,59 @@ public function specifyTypesInCondition( | |||
| $rootExpr, | |||
| ); | |||
| } | |||
| if ( | |||
There was a problem hiding this comment.
if you move this block into the upper if ($expressions !== null) { block, it would work independent of operand order.
atm the code only works for if ($other::class === static::class) {, within the upper IF it would also work for if (static::class === $other::class) {
rvanvelzen
force-pushed
the
static-class-const-equals
branch
from
5154e11 to
8cc986c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.