Simplify code

Author: ondrejmirtes

phpstan-baseline.neon

@@ -277,41 +277,6 @@ parameters:
 			count: 1
 			path: src/Reflection/SignatureMap/Php8SignatureMapProvider.php
 
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiClassExtendsRule.php
-
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiClassImplementsRule.php
-
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiInstantiationRule.php
-
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiInterfaceExtendsRule.php
-
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiMethodCallRule.php
-
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiStaticCallRule.php
-
-		-
-			message: "#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#"
-			count: 1
-			path: src/Rules/Api/ApiTraitUseRule.php
-
 		-
 			message: "#^Binary operation \"\\+\" between array\\{class\\-string\\<TNodeType of PhpParser\\\\Node\\>\\} and array\\<string, class\\-string\\>\\|false results in an error\\.$#"
 			count: 1

src/Rules/Api/ApiClassExtendsRule.php

@@ -42,7 +42,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$extendedClassReflection = $this->reflectionProvider->getClass($extendedClassName);
-		if (!$this->apiRuleHelper->isPhpStanCode($scope, $extendedClassReflection->getName(), $extendedClassReflection->getFileName() ?: null)) {
+		if (!$this->apiRuleHelper->isPhpStanCode($scope, $extendedClassReflection->getName(), $extendedClassReflection->getFileName())) {
 			return [];
 		}
 

src/Rules/Api/ApiClassImplementsRule.php

@@ -54,7 +54,7 @@ private function checkName(Scope $scope, Node\Name $name): array
 		}
 
 		$implementedClassReflection = $this->reflectionProvider->getClass($implementedClassName);
-		if (!$this->apiRuleHelper->isPhpStanCode($scope, $implementedClassReflection->getName(), $implementedClassReflection->getFileName() ?: null)) {
+		if (!$this->apiRuleHelper->isPhpStanCode($scope, $implementedClassReflection->getName(), $implementedClassReflection->getFileName())) {
 			return [];
 		}
 

src/Rules/Api/ApiInstantiationRule.php

@@ -40,7 +40,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$classReflection = $this->reflectionProvider->getClass($className);
-		if (!$this->apiRuleHelper->isPhpStanCode($scope, $classReflection->getName(), $classReflection->getFileName() ?: null)) {
+		if (!$this->apiRuleHelper->isPhpStanCode($scope, $classReflection->getName(), $classReflection->getFileName())) {
 			return [];
 		}
 

src/Rules/Api/ApiInterfaceExtendsRule.php

@@ -54,7 +54,7 @@ private function checkName(Scope $scope, Node\Name $name): array
 		}
 
 		$extendedInterfaceReflection = $this->reflectionProvider->getClass($extendedInterface);
-		if (!$this->apiRuleHelper->isPhpStanCode($scope, $extendedInterfaceReflection->getName(), $extendedInterfaceReflection->getFileName() ?: null)) {
+		if (!$this->apiRuleHelper->isPhpStanCode($scope, $extendedInterfaceReflection->getName(), $extendedInterfaceReflection->getFileName())) {
 			return [];
 		}
 

src/Rules/Api/ApiMethodCallRule.php

@@ -38,7 +38,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$declaringClass = $methodReflection->getDeclaringClass();
-		if (!$this->apiRuleHelper->isPhpStanCode($scope, $declaringClass->getName(), $declaringClass->getFileName() ?: null)) {
+		if (!$this->apiRuleHelper->isPhpStanCode($scope, $declaringClass->getName(), $declaringClass->getFileName())) {
 			return [];
 		}
 

src/Rules/Api/ApiStaticCallRule.php

@@ -53,7 +53,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$methodReflection = $classReflection->getNativeMethod($methodName);
 		$declaringClass = $methodReflection->getDeclaringClass();
-		if (!$this->apiRuleHelper->isPhpStanCode($scope, $declaringClass->getName(), $declaringClass->getFileName() ?: null)) {
+		if (!$this->apiRuleHelper->isPhpStanCode($scope, $declaringClass->getName(), $declaringClass->getFileName())) {
 			return [];
 		}
 

src/Rules/Api/ApiTraitUseRule.php

@@ -41,7 +41,7 @@ public function processNode(Node $node, Scope $scope): array
 			}
 
 			$traitReflection = $this->reflectionProvider->getClass($traitName);
-			if (!$this->apiRuleHelper->isPhpStanCode($scope, $traitReflection->getName(), $traitReflection->getFileName() ?: null)) {
+			if (!$this->apiRuleHelper->isPhpStanCode($scope, $traitReflection->getName(), $traitReflection->getFileName())) {
 				continue;
 			}