Result cache - react to property being virtual changing

Author: ondrejmirtes

src/Dependency/ExportedNode/ExportedPropertiesNode.php

@@ -30,6 +30,7 @@ public function __construct(
 		private bool $publicSet,
 		private bool $protectedSet,
 		private bool $privateSet,
+		private bool $virtual,
 		private array $attributes,
 		private array $hooks,
 	)
@@ -93,7 +94,8 @@ public function equals(ExportedNode $node): bool
 			&& $this->final === $node->final
 			&& $this->publicSet === $node->publicSet
 			&& $this->protectedSet === $node->protectedSet
-			&& $this->privateSet === $node->privateSet;
+			&& $this->privateSet === $node->privateSet
+			&& $this->virtual === $node->virtual;
 	}
 
 	/**
@@ -114,6 +116,7 @@ public static function __set_state(array $properties): self
 			$properties['publicSet'],
 			$properties['protectedSet'],
 			$properties['privateSet'],
+			$properties['virtual'],
 			$properties['attributes'],
 			$properties['hooks'],
 		);
@@ -137,6 +140,7 @@ public static function decode(array $data): self
 			$data['publicSet'],
 			$data['protectedSet'],
 			$data['privateSet'],
+			$data['virtual'],
 			array_map(static function (array $attributeData): ExportedAttributeNode {
 				if ($attributeData['type'] !== ExportedAttributeNode::class) {
 					throw new ShouldNotHappenException();
@@ -173,6 +177,7 @@ public function jsonSerialize()
 				'publicSet' => $this->publicSet,
 				'protectedSet' => $this->protectedSet,
 				'privateSet' => $this->privateSet,
+				'virtual' => $this->virtual,
 				'attributes' => $this->attributes,
 				'hooks' => $this->hooks,
 			],

src/Dependency/ExportedNodeResolver.php

@@ -25,6 +25,7 @@
 use PHPStan\Dependency\ExportedNode\ExportedTraitUseAdaptation;
 use PHPStan\Node\Printer\ExprPrinter;
 use PHPStan\Node\Printer\NodeTypePrinter;
+use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\FileTypeMapper;
 use function array_map;
@@ -34,7 +35,11 @@
 final class ExportedNodeResolver
 {
 
-	public function __construct(private FileTypeMapper $fileTypeMapper, private ExprPrinter $exprPrinter)
+	public function __construct(
+		private ReflectionProvider $reflectionProvider,
+		private FileTypeMapper $fileTypeMapper,
+		private ExprPrinter $exprPrinter,
+	)
 	{
 	}
 
@@ -296,8 +301,17 @@ private function exportClassStatement(Node\Stmt $node, string $fileName, string
 
 			$docComment = $node->getDocComment();
 
+			$names = array_map(static fn (Node\PropertyItem $prop): string => $prop->name->toString(), $node->props);
+			$virtual = false;
+			if ($this->reflectionProvider->hasClass($namespacedName)) {
+				$classReflection = $this->reflectionProvider->getClass($namespacedName);
+				if ($classReflection->hasNativeProperty($names[0])) {
+					$virtual = $classReflection->getNativeProperty($names[0])->isVirtual()->yes();
+				}
+			}
+
 			return new ExportedPropertiesNode(
-				array_map(static fn (Node\PropertyItem $prop): string => $prop->name->toString(), $node->props),
+				$names,
 				$this->exportPhpDocNode(
 					$fileName,
 					$namespacedName,
@@ -314,6 +328,7 @@ private function exportClassStatement(Node\Stmt $node, string $fileName, string
 				$node->isPublicSet(),
 				$node->isProtectedSet(),
 				$node->isPrivateSet(),
+				$virtual,
 				$this->exportAttributeNodes($node->attrGroups),
 				$this->exportPropertyHooks($node->hooks, $fileName, $namespacedName),
 			);

tests/PHPStan/Analyser/AnalyserTest.php

@@ -747,7 +747,7 @@ private function createAnalyser(): Analyser
 				self::getContainer(),
 				new IgnoreLexer(),
 			),
-			new DependencyResolver($fileHelper, $reflectionProvider, new ExportedNodeResolver($fileTypeMapper, new ExprPrinter(new Printer())), $fileTypeMapper),
+			new DependencyResolver($fileHelper, $reflectionProvider, new ExportedNodeResolver($reflectionProvider, $fileTypeMapper, new ExprPrinter(new Printer())), $fileTypeMapper),
 			new IgnoreErrorExtensionProvider(new NetteContainer(new Container([]))),
 			new RuleErrorTransformer(),
 			new LocalIgnoresProcessor(),