Skip to content

Commit e32c9ef

Browse files
committed
Remove @var Type where possible
1 parent b250a8b commit e32c9ef

File tree

2 files changed

+11
-14
lines changed

2 files changed

+11
-14
lines changed

src/Analyser/TypeSpecifier.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,7 @@ public function specifyTypesInCondition(
182182
} elseif ($expr instanceof Node\Expr\BinaryOp\Identical) {
183183
$expressions = $this->findTypeExpressionsFromBinaryOperation($scope, $expr);
184184
if ($expressions !== null) {
185-
/** @var Expr $exprNode */
186185
$exprNode = $expressions[0];
187-
/** @var ConstantScalarType $constantType */
188186
$constantType = $expressions[1];
189187

190188
$specifiedType = $this->specifyTypesForConstantBinaryExpression($exprNode, $constantType, $context, $scope, $rootExpr);
@@ -291,9 +289,7 @@ public function specifyTypesInCondition(
291289
} elseif ($expr instanceof Node\Expr\BinaryOp\Equal) {
292290
$expressions = $this->findTypeExpressionsFromBinaryOperation($scope, $expr);
293291
if ($expressions !== null) {
294-
/** @var Expr $exprNode */
295292
$exprNode = $expressions[0];
296-
/** @var ConstantScalarType $constantType */
297293
$constantType = $expressions[1];
298294
if (!$context->null() && ($constantType->getValue() === false || $constantType->getValue() === null)) {
299295
return $this->specifyTypesInCondition(
@@ -1418,7 +1414,7 @@ private function processBooleanConditionalTypes(Scope $scope, SpecifiedTypes $le
14181414
}
14191415

14201416
/**
1421-
* @return (Expr|ConstantScalarType)[]|null
1417+
* @return array{Expr, ConstantScalarType}|null
14221418
*/
14231419
private function findTypeExpressionsFromBinaryOperation(Scope $scope, Node\Expr\BinaryOp $binaryOperation): ?array
14241420
{

src/Dependency/DependencyResolver.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -115,18 +115,19 @@ public function resolveDependencies(Node $node, Scope $scope): NodeDependencies
115115
}
116116
}
117117
} elseif ($node instanceof Closure || $node instanceof Node\Expr\ArrowFunction) {
118-
/** @var ClosureType $closureType */
119118
$closureType = $scope->getType($node);
120-
foreach ($closureType->getParameters() as $parameter) {
121-
$referencedClasses = $parameter->getType()->getReferencedClasses();
122-
foreach ($referencedClasses as $referencedClass) {
123-
$this->addClassToDependencies($referencedClass, $dependenciesReflections);
119+
if ($closureType instanceof ClosureType) {
120+
foreach ($closureType->getParameters() as $parameter) {
121+
$referencedClasses = $parameter->getType()->getReferencedClasses();
122+
foreach ($referencedClasses as $referencedClass) {
123+
$this->addClassToDependencies($referencedClass, $dependenciesReflections);
124+
}
124125
}
125-
}
126126

127-
$returnTypeReferencedClasses = $closureType->getReturnType()->getReferencedClasses();
128-
foreach ($returnTypeReferencedClasses as $referencedClass) {
129-
$this->addClassToDependencies($referencedClass, $dependenciesReflections);
127+
$returnTypeReferencedClasses = $closureType->getReturnType()->getReferencedClasses();
128+
foreach ($returnTypeReferencedClasses as $referencedClass) {
129+
$this->addClassToDependencies($referencedClass, $dependenciesReflections);
130+
}
130131
}
131132
} elseif ($node instanceof Node\Expr\FuncCall) {
132133
$functionName = $node->name;

0 commit comments

Comments
 (0)