Fix reportPossiblyNonexistentConstantArrayOffset

Author: ondrejmirtes

src/Rules/Arrays/NonexistentOffsetInArrayDimFetchCheck.php

@@ -75,13 +75,15 @@ public function check(
 					$this->reportPossiblyNonexistentGeneralArrayOffset
 					&& $innerType->isArray()->yes()
 					&& !$innerType->isConstantArray()->yes()
+					&& !$innerType->hasOffsetValueType($dimType)->yes()
 				) {
 					$report = true;
 					break;
 				}
 				if (
 					$this->reportPossiblyNonexistentConstantArrayOffset
 					&& $innerType->isConstantArray()->yes()
+					&& !$innerType->hasOffsetValueType($dimType)->yes()
 				) {
 					$report = true;
 					break;

tests/PHPStan/Rules/Arrays/data/report-possibly-nonexistent-array-offset.php

@@ -19,4 +19,24 @@ public function constantArrayWithPossiblyUndefinedArrayOffset(string $s): void
 		$a = ['foo' => 1];
 		echo $a[$s];
 	}
+
+	/**
+	 * @param array{bool|float|int|string|null} $a
+	 * @return void
+	 */
+	public function testConstantArray(array $a): void
+	{
+		echo $a[0];
+	}
+
+	/**
+	 * @param array<int, bool> $a
+	 * @return void
+	 */
+	public function testConstantArray2(array $a): void
+	{
+		if (isset($a[0])) {
+			echo $a[0];
+		}
+	}
 }