Fix ConstantArrayType::toBoolean()

Author: ondrejmirtes

src/Type/Constant/ConstantArrayType.php

@@ -602,7 +602,7 @@ public function slice(int $offset, ?int $limit, bool $preserveKeys = false): sel
 
 	public function toBoolean(): BooleanType
 	{
-		return new ConstantBooleanType(count($this->keyTypes) > 0);
+		return $this->count()->toBoolean();
 	}
 
 	public function generalize(): Type
@@ -690,7 +690,7 @@ public function count(): Type
 	{
 		$optionalKeysCount = count($this->optionalKeys);
 		$totalKeysCount = count($this->getKeyTypes());
-		if ($optionalKeysCount === $totalKeysCount) {
+		if ($optionalKeysCount === 0) {
 			return new ConstantIntegerType($totalKeysCount);
 		}
 

src/Type/IntegerRangeType.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Type;
 
 use PHPStan\TrinaryLogic;
+use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 
 class IntegerRangeType extends IntegerType
@@ -152,6 +153,20 @@ public function toNumber(): Type
 		return new parent();
 	}
 
+	public function toBoolean(): BooleanType
+	{
+		$isZero = (new ConstantIntegerType(0))->isSuperTypeOf($this);
+		if ($isZero->no()) {
+			return new ConstantBooleanType(true);
+		}
+
+		if ($isZero->maybe()) {
+			return new BooleanType();
+		}
+
+		return new ConstantBooleanType(false);
+	}
+
 
 	/**
 	 * @param mixed[] $properties

tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php

@@ -128,4 +128,19 @@ public function testReportPhpDoc(): void
 		]);
 	}
 
+	public function testBug4043(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-4043.php'], [
+			[
+				'If condition is always false.',
+				43,
+			],
+			[
+				'If condition is always true.',
+				50,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-4043.php

@@ -0,0 +1,53 @@
+<?php
+
+namespace Bug4043;
+
+function number(int $diff, string $s): string
+{
+
+}
+
+function (): void {
+	$uppedDate = new \DateTime('now -1s');
+	$diff = $uppedDate->diff(new \DateTime());
+	assert($diff !== false);
+
+	$mdiff = (int)$diff->format('%m');
+	$ddiff = (int)$diff->format('%d');
+	$hdiff = (int)$diff->format('%H');
+	$idiff = (int)$diff->format('%i');
+
+	$m = $mdiff ? number($mdiff, 'месяц|месяца|месяцев') : '';
+	$d = $ddiff ? number($ddiff, 'день|дня|дней') : '';
+	$h = $hdiff ? number($hdiff, 'час|часа|часов') : '';
+	$i = $idiff ? number($idiff, 'минута|минуты|минут') : '';
+
+	$content = array_filter([$m, $d, $h, $i]);
+	if ($content) {
+		echo 1;
+	}
+};
+
+function (): void {
+	$a = [];
+	if (rand(0, 1)) {
+		$a[] = 1;
+	}
+	if ($a) {
+
+	}
+};
+
+function (): void {
+	$a = [];
+	if ($a) {
+
+	}
+};
+
+function (): void {
+	$a = [1];
+	if ($a) {
+
+	}
+};