Fix preg_match_all behaviour with no flags

ondrejmirtes · ondrejmirtes · commit a856ec7ab554 · 2024-03-29T13:32:54.000+01:00
diff --git a/stubs/core.stub b/stubs/core.stub
@@ -193,7 +193,7 @@ function sscanf(string $string, string $format, &$war, &...$vars) {}
  *                              ? list<array<?string>>
  *                              : (TFlags is 770
  *                                  ? list<array<array{?string, int}>>
- *                                  : array<mixed>
+ *                                  : (TFlags is 0 ? array<list<string>> : array<mixed>)
  *                              )
  *                          )
  *                      )
diff --git a/tests/PHPStan/Analyser/data/param-out-default.php b/tests/PHPStan/Analyser/data/param-out-default.php
@@ -27,4 +27,10 @@ public function doBar(): void
 		assertType('array<int>', $c);
 	}
 
+	public function sayHello(string $row): void
+	{
+		preg_match_all('#// error:(.+)#', $row, $matches);
+		assertType('array<list<string>>', $matches);
+	}
+
 }

Original file line number	Diff line number	Diff line change
`@@ -27,4 +27,10 @@ public function doBar(): void`
`27`	`27`	`assertType('array<int>', $c);`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ public function sayHello(string $row): void`
	`31`	`+ {`
	`32`	`+ preg_match_all('#// error:(.+)#', $row, $matches);`
	`33`	`+ assertType('array<list<string>>', $matches);`
	`34`	`+ }`
	`35`	`+`
`30`	`36`	`}`