String value passed to Identifier cannot be empty

Author: ondrejmirtes

build/phpstan.neon

@@ -97,6 +97,7 @@ parameters:
 		- stubs/ReactStreams.stub
 		- stubs/NetteDIContainer.stub
 		- stubs/PhpParserName.stub
+		- stubs/Identifier.stub
 
 rules:
 	- PHPStan\Build\FinalClassRule

build/stubs/Identifier.stub

@@ -0,0 +1,15 @@
+<?php declare(strict_types=1);
+
+namespace PhpParser\Node;
+
+use PhpParser\NodeAbstract;
+
+class Identifier extends NodeAbstract {
+
+    /**
+     * @param non-empty-string $name
+     * @param array<string, mixed> $attributes
+     */
+    public function __construct(string $name, array $attributes = []) { }
+
+}

src/Analyser/MutatingScope.php

@@ -2075,7 +2075,7 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 			$nameType = $this->getType($node->name);
 			if (count($nameType->getConstantStrings()) > 0) {
 				return TypeCombinator::union(
-					...array_map(fn ($constantString) => $this
+					...array_map(fn ($constantString) => $constantString->getValue() === '' ? new ErrorType() : $this
 						->filterByTruthyValue(new BinaryOp\Identical($node->name, new String_($constantString->getValue())))
 						->getType(new MethodCall($node->var, new Identifier($constantString->getValue()), $node->args)), $nameType->getConstantStrings()),
 				);
@@ -2155,7 +2155,7 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 			$nameType = $this->getType($node->name);
 			if (count($nameType->getConstantStrings()) > 0) {
 				return TypeCombinator::union(
-					...array_map(fn ($constantString) => $this
+					...array_map(fn ($constantString) => $constantString->getValue() === '' ? new ErrorType() : $this
 						->filterByTruthyValue(new BinaryOp\Identical($node->name, new String_($constantString->getValue())))
 						->getType(new Expr\StaticCall($node->class, new Identifier($constantString->getValue()), $node->args)), $nameType->getConstantStrings()),
 				);
@@ -2197,7 +2197,7 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 			$nameType = $this->getType($node->name);
 			if (count($nameType->getConstantStrings()) > 0) {
 				return TypeCombinator::union(
-					...array_map(fn ($constantString) => $this
+					...array_map(fn ($constantString) => $constantString->getValue() === '' ? new ErrorType() : $this
 						->filterByTruthyValue(new BinaryOp\Identical($node->name, new String_($constantString->getValue())))
 						->getType(
 							new PropertyFetch($node->var, new Identifier($constantString->getValue())),
@@ -2271,7 +2271,7 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 			$nameType = $this->getType($node->name);
 			if (count($nameType->getConstantStrings()) > 0) {
 				return TypeCombinator::union(
-					...array_map(fn ($constantString) => $this
+					...array_map(fn ($constantString) => $constantString->getValue() === '' ? new ErrorType() : $this
 						->filterByTruthyValue(new BinaryOp\Identical($node->name, new String_($constantString->getValue())))
 						->getType(new Expr\StaticPropertyFetch($node->class, new Node\VarLikeIdentifier($constantString->getValue()))), $nameType->getConstantStrings()),
 				);
@@ -5695,6 +5695,10 @@ private function exactInstantiation(New_ $node, string $className): ?Type
 			$constructorMethod = new DummyConstructorReflection($classReflection);
 		}
 
+		if ($constructorMethod->getName() === '') {
+			throw new ShouldNotHappenException();
+		}
+
 		$resolvedTypes = [];
 		$methodCall = new Expr\StaticCall(
 			new Name($resolvedClassName),

src/Analyser/NodeScopeResolver.php

@@ -686,7 +686,7 @@ private function processStmtNode(
 						continue;
 					}
 
-					if (!$param->var instanceof Variable || !is_string($param->var->name)) {
+					if (!$param->var instanceof Variable || !is_string($param->var->name) || $param->var->name === '') {
 						throw new ShouldNotHappenException();
 					}
 					$phpDoc = null;

src/Broker/AnonymousClassNameHelper.php

@@ -20,6 +20,9 @@ public function __construct(
 	{
 	}
 
+	/**
+	 * @return non-empty-string
+	 */
 	public function getAnonymousClassName(
 		Node\Stmt\Class_ $classNode,
 		string $filename,

src/Node/ClassPropertyNode.php

@@ -15,6 +15,9 @@
 final class ClassPropertyNode extends NodeAbstract implements VirtualNode
 {
 
+	/**
+	 * @param non-empty-string $name
+	 */
 	public function __construct(
 		private string $name,
 		private int $flags,
@@ -35,6 +38,7 @@ public function __construct(
 		parent::__construct($originalNode->getAttributes());
 	}
 
+	/** @return non-empty-string */
 	public function getName(): string
 	{
 		return $this->name;

src/Node/ClassStatementsGatherer.php

@@ -259,6 +259,9 @@ private function tryToApplyPropertyReads(Expr\FuncCall $node, Scope $scope): voi
 			if ($property->isStatic()) {
 				continue;
 			}
+			if ($property->getName() === '') {
+				throw new ShouldNotHappenException();
+			}
 			$this->propertyUsages[] = new PropertyRead(
 				new PropertyFetch(new Expr\Variable('this'), new Identifier($property->getName())),
 				$scope,
@@ -282,6 +285,9 @@ private function tryToApplyPropertyWritesFromAncestorConstructor(StaticCall $anc
 			if (!$property->isPromoted() || $property->getDeclaringClass()->getName() !== $classReflection->getName()) {
 				continue;
 			}
+			if ($property->getName() === '') {
+				throw new ShouldNotHappenException();
+			}
 			$this->propertyUsages[] = new PropertyWrite(
 				new PropertyFetch(new Expr\Variable('this'), new Identifier($property->getName()), $ancestorConstructorCall->getAttributes()),
 				$scope,

src/Reflection/ClassReflection.php

@@ -1332,6 +1332,9 @@ private function findAttributeFlags(): ?int
 			$attributeClass = $this->reflectionProvider->getClass(Attribute::class);
 			$arguments = [];
 			foreach ($nativeAttributes[0]->getArgumentsExpressions() as $i => $expression) {
+				if ($i === '') {
+					throw new ShouldNotHappenException();
+				}
 				$arguments[] = new Arg($expression, false, false, [], is_int($i) ? null : new Identifier($i));
 			}
 

src/Type/Php/ConstantHelper.php

@@ -24,7 +24,7 @@ public function createExprFromConstantName(string $constantName): ?Expr
 		$classConstParts = explode('::', $constantName);
 		if (count($classConstParts) >= 2) {
 			$fqcn = ltrim($classConstParts[0], '\\');
-			if ($fqcn === '') {
+			if ($fqcn === '' || $classConstParts[1] === '') {
 				return null;
 			}
 

src/Type/Php/PropertyExistsTypeSpecifyingExtension.php

@@ -56,6 +56,10 @@ public function specifyTypes(
 			return new SpecifiedTypes([], []);
 		}
 
+		if ($propertyNameType->getValue() === '') {
+			return new SpecifiedTypes([], []);
+		}
+
 		$objectType = $scope->getType($node->getArgs()[0]->value);
 		if ($objectType instanceof ConstantStringType) {
 			return new SpecifiedTypes([], []);