Fix AccessoryLiteralStringType::setOffsetValueType()

phpstan · Aug 14, 2024 · 93c5226 · 93c5226
1 parent c19155c
commit 93c5226
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/Type/Accessory/AccessoryLiteralStringType.php b/src/Type/Accessory/AccessoryLiteralStringType.php
@@ -153,7 +153,11 @@ public function getOffsetValueType(Type $offsetType): Type
 
 	public function setOffsetValueType(?Type $offsetType, Type $valueType, bool $unionValues = true): Type
 	{
-		return $this;
+		if ($valueType->isLiteralString()->yes()) {
+			return $this;
+		}
+
+		return new StringType();
 	}
 
 	public function setExistingOffsetValueType(Type $offsetType, Type $valueType): Type

diff --git a/tests/PHPStan/Analyser/nsrt/bug-3981.php b/tests/PHPStan/Analyser/nsrt/bug-3981.php
@@ -27,4 +27,17 @@ public function doFoo(string $s, string $nonEmptyString): void
 		assertType('non-empty-string', $s);
 	}
 
+	/**
+	 * @param literal-string $literalString
+	 * @param literal-string $anotherLiteralString
+	 */
+	public function doBar(string $literalString, string $generalString): void
+	{
+		$literalString[0] = 'a';
+		assertType('literal-string&non-empty-string', $literalString);
+
+		$literalString[1] = $generalString;
+		assertType('non-empty-string', $literalString);
+	}
+
 }