Object with dynamic property assignments cannot report too-wide types on properties

Author: ondrejmirtes

src/Rules/TooWideTypehints/TooWideTypeCheck.php

@@ -62,6 +62,9 @@ public function checkProperty(
 		foreach ($propertyAssigns as $assign) {
 			$assignNode = $assign->getAssign();
 			$assignPropertyReflections = $this->propertyReflectionFinder->findPropertyReflectionsFromNode($assignNode->getPropertyFetch(), $assign->getScope());
+			if (count($assignPropertyReflections) === 0) {
+				return [];
+			}
 			foreach ($assignPropertyReflections as $assignPropertyReflection) {
 				if ($node->getName() !== $assignPropertyReflection->getName()) {
 					continue;

tests/PHPStan/Rules/TooWideTypehints/TooWidePropertyTypeRuleTest.php

@@ -131,4 +131,11 @@ public function testNestedTooWideType(): void
 		]);
 	}
 
+	public function testBug13624(): void
+	{
+		$this->reportTooWideBool = true;
+		$this->reportNestedTooWideType = true;
+		$this->analyse([__DIR__ . '/data/bug-13624.php'], []);
+	}
+
 }

tests/PHPStan/Rules/TooWideTypehints/data/bug-13624.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Bug13624;
+
+class Example
+{
+
+	/** @var ?string */
+	private $exampleProperty;
+	/** @var string */
+	private $exampleProperty2;
+	/** @var ?int */
+	private $exampleProperty3;
+	/** @var int */
+	private $exampleProperty4;
+	/** This is fine if uninitialized property warnings are off */
+	private ?int $exampleProperty5;
+
+
+	/** @param array<string, int|float|string|null> $row */
+	public static function from_db_row(array $row): self
+	{
+		$course = new self();
+		foreach ($row as $key => $value) {
+			$course->{$key} = $value;
+		}
+		return $course;
+	}
+
+}