Fix

phpstan · Aug 26, 2024 · 7d85a3a · 7d85a3a
1 parent b5d418c
commit 7d85a3a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/src/Php/PhpVersion.php b/src/Php/PhpVersion.php
@@ -338,11 +338,6 @@ public function isCurloptUrlCheckingFileSchemeWithOpenBasedir(): bool
 		return $this->versionId < 80000;
 	}
 
-	public function hasExitAsFunction(): bool
-	{
-		return $this->versionId >= 80400;
-	}
-
 	public function highlightStringDoesNotReturnFalse(): bool
 	{
 		return $this->versionId >= 80400;

diff --git a/src/Reflection/BetterReflection/BetterReflectionProvider.php b/src/Reflection/BetterReflection/BetterReflectionProvider.php
@@ -266,10 +266,8 @@ public function getFunction(Node\Name $nameNode, ?NamespaceAnswerer $namespaceAn
 			return $this->functionReflections[$lowerCasedFunctionName];
 		}
 
-		if ($this->phpVersion->hasExitAsFunction()) {
-			if (in_array($lowerCasedFunctionName, ['exit', 'die'], true)) {
-				return $this->functionReflections[$lowerCasedFunctionName] = new ExitFunctionReflection($lowerCasedFunctionName);
-			}
+		if (in_array($lowerCasedFunctionName, ['exit', 'die'], true)) {
+			return $this->functionReflections[$lowerCasedFunctionName] = new ExitFunctionReflection($lowerCasedFunctionName);
 		}
 
 		$nativeFunctionReflection = $this->nativeFunctionReflectionProvider->findFunctionReflection($lowerCasedFunctionName);
@@ -351,12 +349,11 @@ private function getCustomFunction(string $functionName): PhpFunctionReflection
 
 	public function resolveFunctionName(Node\Name $nameNode, ?NamespaceAnswerer $namespaceAnswerer): ?string
 	{
-		if ($this->phpVersion->hasExitAsFunction()) {
-			$name = $nameNode->toLowerString();
-			if (in_array($name, ['exit', 'die'], true)) {
-				return $name;
-			}
+		$name = $nameNode->toLowerString();
+		if (in_array($name, ['exit', 'die'], true)) {
+			return $name;
 		}
+
 		return $this->resolveName($nameNode, function (string $name): bool {
 			try {
 				$this->reflector->reflectFunction($name);