Regression tests

Closes phpstan/phpstan#8958
Closes phpstan/phpstan#8563

Author: ondrejmirtes

tests/PHPStan/Rules/Properties/MissingReadOnlyPropertyAssignRuleTest.php

@@ -138,4 +138,22 @@ public function testBug8412(): void
 		$this->analyse([__DIR__ . '/data/bug-8412.php'], []);
 	}
 
+	public function testBug8958(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
+		}
+
+		$this->analyse([__DIR__ . '/data/bug-8958.php'], []);
+	}
+
+	public function testBug8563(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
+		}
+
+		$this->analyse([__DIR__ . '/data/bug-8563.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-8563.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Bug8563;
+
+class BankAccount {
+
+	readonly string $bic;
+	readonly string $iban;
+	readonly string $label;
+
+	function __construct(object $data = new \stdClass) {
+		$this->bic = $data->bic ?? "";
+		$this->iban = $data->iban ?? "";
+		$this->label = $data->label ?? "";
+	}
+}

tests/PHPStan/Rules/Properties/data/bug-8958.php

@@ -0,0 +1,69 @@
+<?php declare(strict_types=1);
+
+namespace Bug8958;
+
+interface TimeRangeInterface
+{
+	public function getStart(): \DateTimeInterface;
+
+	public function getEnd(): \DateTimeInterface;
+}
+
+trait TimeRangeTrait
+{
+	private readonly \DateTimeImmutable $start;
+
+	private readonly \DateTimeImmutable $end;
+
+	public function getStart(): \DateTimeImmutable
+	{
+		return $this->start; // @phpstan-ignore-line
+	}
+
+	public function getEnd(): \DateTimeImmutable
+	{
+		return $this->end; // @phpstan-ignore-line
+	}
+
+	private function initTimeRange(
+		\DateTimeInterface $start,
+		\DateTimeInterface $end
+	): void {
+		$this->start = \DateTimeImmutable::createFromInterface($start); // @phpstan-ignore-line
+		$this->end = \DateTimeImmutable::createFromInterface($end); // @phpstan-ignore-line
+	}
+}
+
+class Foo implements TimeRangeInterface {
+	use TimeRangeTrait;
+
+	public function __construct(\DateTimeInterface $start, \DateTimeInterface $end)
+	{
+		$this->initTimeRange($start, $end);
+	}
+}
+
+class Bar implements TimeRangeInterface {
+	use TimeRangeTrait;
+
+	public function __construct(
+		private TimeRangeInterface $first,
+		private TimeRangeInterface $second,
+		?\DateTimeInterface $start = null,
+		\DateTimeInterface $end = null
+	) {
+		$this->initTimeRange(
+			$start ?? max($first->getStart(), $second->getStart()),
+			$end ?? min($first->getEnd(), $second->getEnd()),
+		);
+	}
+
+	public function getFirst(): TimeRangeInterface
+	{
+		return $this->first;
+	}
+	public function getSecond(): TimeRangeInterface
+	{
+		return $this->second;
+	}
+}