Regression tests

Closes phpstan/phpstan#2689
Closes phpstan/phpstan#2714
Closes phpstan/phpstan#2846

Author: ondrejmirtes

tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php

@@ -258,4 +258,14 @@ public function testBug1664(): void
 		$this->analyse([__DIR__ . '/data/bug-1664.php'], []);
 	}
 
+	public function testBug2689(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-2689.php'], [
+			[
+				'Cannot access an offset on callable.',
+				14,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Arrays/data/bug-2689.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Bug2689;
+
+class HelloWorld
+{
+	/**
+	 * @var callable[]
+	 */
+	private $listeners;
+
+	public function addListener(string $name, callable $callback): void
+	{
+		$this->listeners[$name][] = $callback;
+	}
+}

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -392,4 +392,11 @@ public function testBug1613(): void
 		$this->analyse([__DIR__ . '/data/bug-1613.php'], []);
 	}
 
+	public function testBug2714(): void
+	{
+		$this->checkAlwaysTrueCheckTypeFunctionCall = true;
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-2714.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Comparison/data/bug-2714.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Bug2714;
+
+function (): void
+{
+	$list = [];
+
+	// creation of unpredictable values at 'type' key
+	for ($i = 0; $i < 3; $i++) {
+		$list[] = [
+			'type' => str_repeat('a', rand(1, 10)),
+		];
+	}
+
+	$list[] = [
+		'type' => 'x',
+	];
+
+	foreach ($list as $item) {
+		if (in_array($item['type'], ['aaa', 'aaaa'], TRUE)) {
+			echo 'OK';
+		}
+	}
+};

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -492,4 +492,9 @@ public function testBug2434(): void
 		$this->analyse([__DIR__ . '/data/bug-2434.php'], []);
 	}
 
+	public function testBug2846(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-2846.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/bug-2846.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Bug2846;
+
+class Test {
+	public static function staticFunc(): void {}
+	public static function callStatic(): void {
+		call_user_func([static::class, 'staticFunc']);
+	}
+}