Improve function signatures with functionMap only for built-in symbols

Author: ondrejmirtes

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -579,7 +579,7 @@ private function createMethod(
 			return new EnumCasesMethodReflection($declaringClass, $arrayBuilder->getArray());
 		}
 
-		if ($this->signatureMapProvider->hasMethodSignature($declaringClassName, $methodReflection->getName())) {
+		if (($declaringClass->isBuiltin() || $declaringClass->isEnum()) && $this->signatureMapProvider->hasMethodSignature($declaringClassName, $methodReflection->getName())) {
 			$variantsByType = ['positional' => []];
 			$throwType = null;
 			$asserts = Assertions::createEmpty();
@@ -880,12 +880,14 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 		$isInternal = $resolvedPhpDoc->isInternal();
 		$isFinal = $resolvedPhpDoc->isFinal();
 		$isPure = null;
-		foreach (array_keys($actualDeclaringClass->getAncestors()) as $className) {
-			if ($this->signatureMapProvider->hasMethodMetadata($className, $methodReflection->getName())) {
-				$hasSideEffects = $this->signatureMapProvider->getMethodMetadata($className, $methodReflection->getName())['hasSideEffects'];
-				$isPure = !$hasSideEffects;
+		if ($actualDeclaringClass->isBuiltin() || $actualDeclaringClass->isEnum()) {
+			foreach (array_keys($actualDeclaringClass->getAncestors()) as $className) {
+				if ($this->signatureMapProvider->hasMethodMetadata($className, $methodReflection->getName())) {
+					$hasSideEffects = $this->signatureMapProvider->getMethodMetadata($className, $methodReflection->getName())['hasSideEffects'];
+					$isPure = !$hasSideEffects;
 
-				break;
+					break;
+				}
 			}
 		}
 

src/Reflection/SignatureMap/NativeFunctionReflectionProvider.php

@@ -24,6 +24,7 @@
 use PHPStan\Type\TypehintHelper;
 use function array_key_exists;
 use function array_map;
+use function str_contains;
 use function strtolower;
 
 #[AutowiredService]
@@ -75,6 +76,9 @@ public function findFunctionReflection(string $functionName): ?NativeFunctionRef
 			$isDeprecated = $reflectionFunction->isDeprecated();
 			if ($reflectionFunction->getFileName() !== null) {
 				$fileName = $reflectionFunction->getFileName();
+				if (!$reflectionFunctionAdapter->isInternal() && !str_contains(strtolower($fileName), 'polyfill')) {
+					return null;
+				}
 				$docComment = $reflectionFunction->getDocComment();
 				if ($docComment !== null) {
 					$resolvedPhpDoc = $this->fileTypeMapper->getResolvedPhpDoc($fileName, null, null, $reflectionFunction->getName(), $docComment);

tests/PHPStan/Reflection/ParametersAcceptorSelectorTest.php

@@ -44,7 +44,6 @@ class ParametersAcceptorSelectorTest extends PHPStanTestCase
 	 */
 	public static function dataSelectFromTypes(): Generator
 	{
-		require_once __DIR__ . '/data/function-definitions.php';
 		$reflectionProvider = self::createReflectionProvider();
 
 		$arrayRandVariants = $reflectionProvider->getFunction(new Name('array_rand'), null)->getVariants();
@@ -185,7 +184,7 @@ public static function dataSelectFromTypes(): Generator
 						new MixedType(),
 						PassedByReference::createNo(),
 						true,
-						null,
+						new NullType(),
 					),
 				],
 				true,

tests/PHPStan/Reflection/data/function-definitions.php

@@ -2324,4 +2324,11 @@ public function testBug13197(): void
 		$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-13197.php'], []);
 	}
 
+	public function testBug13556(): void
+	{
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+		$this->analyse([__DIR__ . '/data/bug-13556.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -0,0 +1,7 @@
+<?php
+
+function swf_actiongotoframe($string) {
+
+}
+
+swf_actiongotoframe('string');

tests/PHPStan/Rules/Functions/data/bug-13556.php

@@ -907,4 +907,13 @@ public function testRestrictedInternalClassNameUsage(): void
 		]);
 	}
 
+	public function testBug13556(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkExplicitMixed = true;
+		$this->checkImplicitMixed = true;
+
+		$this->analyse([__DIR__ . '/data/bug-13556.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php

@@ -0,0 +1,11 @@
+<?php
+
+class event {
+	public static function add($_event, $_option = []) {
+		// $_option est optionnel avec valeur par défaut
+	}
+
+	public static function callAdd() {
+		self::add('a',[]); // Appel avec 2 paramètres (1 requis + 1 optionnel)
+	}
+}