Do not check abstract properties as uninitialized

phpstan · Jan 24, 2025 · 1cc5347 · 1cc5347
1 parent f436584
commit 1cc5347
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/src/Node/ClassPropertiesNode.php b/src/Node/ClassPropertiesNode.php
@@ -118,6 +118,9 @@ public function getUninitializedProperties(
 			if ($property->isStatic()) {
 				continue;
 			}
+			if ($property->isAbstract()) {
+				continue;
+			}
 			if ($property->getNativeType() === null) {
 				continue;
 			}

diff --git a/tests/PHPStan/Rules/Properties/UninitializedPropertyRuleTest.php b/tests/PHPStan/Rules/Properties/UninitializedPropertyRuleTest.php
@@ -7,6 +7,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use function strpos;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<UninitializedPropertyRule>
@@ -216,4 +217,13 @@ public function testRedeclareReadonlyProperties(): void
 		]);
 	}
 
+	public function testBug12336(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/bug-12336.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Properties/data/bug-12336.php b/tests/PHPStan/Rules/Properties/data/bug-12336.php
@@ -0,0 +1,7 @@
+<?php // lint >= 8.4
+
+namespace Bug12336;
+
+abstract class ListItem {
+	abstract public int $item { get; }
+}