Fix covers rule for functions.

phpstan · Oct 28, 2022 · c86e460 · c86e460
1 parent e431a6c
commit c86e460
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/src/Rules/PHPUnit/CoversHelper.php b/src/Rules/PHPUnit/CoversHelper.php
@@ -3,6 +3,7 @@
 namespace PHPStan\Rules\PHPUnit;
 
 use PhpParser\Node;
+use PhpParser\Node\Name;
 use PHPStan\PhpDoc\ResolvedPhpDocBlock;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
 use PHPStan\Reflection\ReflectionProvider;
@@ -70,8 +71,9 @@ public function processCovers(
 	{
 		$errors = [];
 		$covers = (string) $phpDocTag->value;
+		$isMethod = strpos($covers, '::') !== false;
 
-		if (strpos($covers, '::') !== false) {
+		if ($isMethod) {
 			[$className, $method] = explode('::', $covers);
 		} else {
 			$className = $covers;
@@ -83,16 +85,22 @@ public function processCovers(
 
 		if ($this->reflectionProvider->hasClass($className)) {
 			$class = $this->reflectionProvider->getClass($className);
+
 			if (isset($method) && $method !== '' && !$class->hasMethod($method)) {
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'@covers value %s references an invalid method.',
 					$covers
 				))->build();
 			}
 		} else {
+			if (!isset($method) && $this->reflectionProvider->hasFunction(new Name($covers, []), null)) {
+				return $errors;
+			}
+
 			$errors[] = RuleErrorBuilder::message(sprintf(
-				'@covers value %s references an invalid class.',
-				$covers
+				'@covers value %s references an invalid %s.',
+				$covers,
+				$isMethod ? 'method' : 'class or function'
 			))->build();
 		}
 		return $errors;

diff --git a/tests/Rules/PHPUnit/ClassMethodCoversExistsRuleTest.php b/tests/Rules/PHPUnit/ClassMethodCoversExistsRuleTest.php
@@ -26,15 +26,15 @@ public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/method-coverage.php'], [
 			[
-				'@covers value ::ignoreThis references an invalid class.',
+				'@covers value ::ignoreThis references an invalid method.',
 				14,
 			],
 			[
 				'@covers value \PHPUnit\Framework\TestCase::assertNotReal references an invalid method.',
 				28,
 			],
 			[
-				'@covers value \Not\A\Class::foo references an invalid class.',
+				'@covers value \Not\A\Class::foo references an invalid method.',
 				35,
 			],
 			[

diff --git a/tests/Rules/PHPUnit/data/class-coverage.php b/tests/Rules/PHPUnit/data/class-coverage.php
@@ -23,3 +23,15 @@ class CoversShouldExistTestCase2 extends \PHPUnit\Framework\TestCase
 class MultipleCoversDefaultClass extends \PHPUnit\Framework\TestCase
 {
 }
+
+/**
+ * @covers \ClassCoverage\testable
+ */
+class CoversFunction extends \PHPUnit\Framework\TestCase
+{
+}
+
+function testable(): void
+{
+
+}