Fix MockMethodCallRule

phpstan · Feb 21, 2023 · 4b17a23 · 4b17a23
1 parent abc2da9
commit 4b17a23
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/Rules/PHPUnit/MockMethodCallRule.php b/src/Rules/PHPUnit/MockMethodCallRule.php
@@ -56,15 +56,19 @@ public function processNode(Node $node, Scope $scope): array
 				)
 				&& !$type->hasMethod($method)->yes()
 			) {
-				$mockClass = array_filter($type->getObjectClassNames(), static function (string $class): bool {
+				$mockClasses = array_filter($type->getObjectClassNames(), static function (string $class): bool {
 					return $class !== MockObject::class && $class !== Stub::class;
 				});
+				if (count($mockClasses) === 0) {
+					continue;
+				}
 
 				$errors[] = sprintf(
 					'Trying to mock an undefined method %s() on class %s.',
 					$method,
-					implode('&', $mockClass)
+					implode('&', $mockClasses)
 				);
+				continue;
 			}
 
 			$mockedClassObject = $type->getTemplateType(InvocationMocker::class, 'TMockedClass');

diff --git a/tests/Rules/PHPUnit/data/mock-method-call.php b/tests/Rules/PHPUnit/data/mock-method-call.php
@@ -36,6 +36,11 @@ public function testBadMethodOnStub()
 		$this->createStub(Bar::class)->method('doBadThing');
 	}
 
+	public function testMockObject(\PHPUnit\Framework\MockObject\MockObject $mock)
+	{
+		$mock->method('doFoo');
+	}
+
 }
 
 class Bar {