Improve logic MockMethodCallRule to search for method even on wrong type

Author: ondrejmirtes

src/Rules/PHPUnit/MockMethodCallRule.php

@@ -48,7 +48,7 @@ public function processNode(Node $node, Scope $scope): array
 			$method = $constantString->getValue();
 			$type = $scope->getType($node->var);
 
-			$error = $this->checkCallOnType($type, $method);
+			$error = $this->checkCallOnType($scope, $type, $method);
 			if ($error !== null) {
 				$errors[] = $error;
 				continue;
@@ -67,7 +67,7 @@ public function processNode(Node $node, Scope $scope): array
 			}
 
 			$varType = $scope->getType($node->var->var);
-			$error = $this->checkCallOnType($varType, $method);
+			$error = $this->checkCallOnType($scope, $varType, $method);
 			if ($error === null) {
 				continue;
 			}
@@ -78,14 +78,16 @@ public function processNode(Node $node, Scope $scope): array
 		return $errors;
 	}
 
-	private function checkCallOnType(Type $type, string $method): ?IdentifierRuleError
+	private function checkCallOnType(Scope $scope, Type $type, string $method): ?IdentifierRuleError
 	{
+		$methodReflection = $scope->getMethodReflection($type, $method);
+		if ($methodReflection !== null) {
+			return null;
+		}
+
 		if (
-			(
-				in_array(MockObject::class, $type->getObjectClassNames(), true)
-				|| in_array(Stub::class, $type->getObjectClassNames(), true)
-			)
-			&& !$type->hasMethod($method)->yes()
+			in_array(MockObject::class, $type->getObjectClassNames(), true)
+			|| in_array(Stub::class, $type->getObjectClassNames(), true)
 		) {
 			$mockClasses = array_filter($type->getObjectClassNames(), static fn (string $class): bool => $class !== MockObject::class && $class !== Stub::class);
 			if (count($mockClasses) === 0) {

tests/Rules/PHPUnit/MockMethodCallRuleTest.php

@@ -36,6 +36,11 @@ public function testRule(): void
 		$this->analyse([__DIR__ . '/data/mock-method-call.php'], $expectedErrors);
 	}
 
+	public function testBug227(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-227.php'], []);
+	}
+
 	/**
 	 * @return string[]
 	 */

tests/Rules/PHPUnit/data/bug-227.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace Bug227;
+
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+use stdClass;
+
+class Foo
+{
+
+	public function addCacheTags(array $tags)
+	{
+
+	}
+
+	public function getLanguage(): stdClass
+	{
+
+	}
+
+}
+
+class SomeTest extends TestCase
+{
+
+	protected MockObject|Foo $tsfe;
+
+	protected function setUp(): void
+	{
+		$this->tsfe = $this->getMockBuilder(Foo::class)
+			->onlyMethods(['addCacheTags', 'getLanguage'])
+			->disableOriginalConstructor()
+			->getMock();
+		$this->tsfe->method('getLanguage')->willReturn('aaa');
+	}
+
+	public function testSometest(): void
+	{
+		$this->tsfe->expects(self::once())->method('addCacheTags');
+	}
+}