RegularExpressionPatternRule: support extended Strings

Author: janedbal

src/Rule/Nette/RegularExpressionPatternRule.php

@@ -51,8 +51,8 @@ private function extractPatterns(StaticCall $staticCall, Scope $scope): array
 		if (!$staticCall->class instanceof Node\Name || !$staticCall->name instanceof Node\Identifier) {
 			return [];
 		}
-		$className = $scope->resolveName($staticCall->class);
-		if ($className !== Strings::class) {
+		$caller = $scope->resolveTypeByName($staticCall->class);
+		if ($caller->getClassReflection() === null || !$caller->getClassReflection()->is(Strings::class)) {
 			return [];
 		}
 		$methodName = strtolower((string) $staticCall->name);

tests/Rule/Nette/RegularExpressionPatternRuleTest.php

@@ -71,6 +71,10 @@ public function testValidRegexPatternAfter73(): void
 					'Regex pattern is invalid: Compilation failed: missing closing parenthesis at offset 1 in pattern: ~(~',
 					26,
 				],
+				[
+					'Regex pattern is invalid: Delimiter must not be alphanumeric, backslash, or NUL in pattern: nok',
+					36,
+				],
 			],
 		);
 	}

tests/Rule/Nette/data/valid-regex-pattern.php

@@ -31,3 +31,6 @@
 		'~(~' => function () {},
 	]
 );
+
+class MyStrings extends \Nette\Utils\Strings {}
+MyStrings::replace('', 'nok', '');