TemplateTagValueNode name cannot be empty string

phpstan · May 31, 2024 · fcaefac · fcaefac
1 parent 536889f
commit fcaefac
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/Ast/PhpDoc/TemplateTagValueNode.php b/src/Ast/PhpDoc/TemplateTagValueNode.php
@@ -11,7 +11,7 @@ class TemplateTagValueNode implements PhpDocTagValueNode
 
 	use NodeAttributes;
 
-	/** @var string */
+	/** @var non-empty-string */
 	public $name;
 
 	/** @var TypeNode|null */
@@ -23,6 +23,9 @@ class TemplateTagValueNode implements PhpDocTagValueNode
 	/** @var string (may be empty) */
 	public $description;
 
+	/**
+	 * @param non-empty-string $name
+	 */
 	public function __construct(string $name, ?TypeNode $bound, string $description, ?TypeNode $default = null)
 	{
 		$this->name = $name;

diff --git a/src/Parser/TypeParser.php b/src/Parser/TypeParser.php
@@ -510,6 +510,10 @@ public function parseTemplateTagValue(
 			$description = '';
 		}
 
+		if ($name === '') {
+			throw new LogicException('Template tag name cannot be empty.');
+		}
+
 		return new Ast\PhpDoc\TemplateTagValueNode($name, $bound, $description, $default);
 	}
 

diff --git a/tests/PHPStan/Printer/PrinterTest.php b/tests/PHPStan/Printer/PrinterTest.php
@@ -1792,7 +1792,7 @@ public function enterNode(Node $node)
 	}
 
 	/**
-	 * @return iterable<list{TypeNode, string}>
+	 * @return iterable<array{TypeNode, string}>
 	 */
 	public function dataPrintType(): iterable
 	{
@@ -1905,7 +1905,7 @@ public function testPrintType(TypeNode $node, string $expectedResult): void
 	}
 
 	/**
-	 * @return iterable<list{PhpDocNode, string}>
+	 * @return iterable<array{PhpDocNode, string}>
 	 */
 	public function dataPrintPhpDocNode(): iterable
 	{