Fix the null/false mess

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

Author: kamil-tekiela

phpstan-baseline.neon

@@ -1,30 +1,10 @@
 parameters:
 	ignoreErrors:
-		-
-			message: "#^Parameter \\#1 \\$shpFile of method PhpMyAdmin\\\\ShapeFile\\\\ShapeRecord\\:\\:saveToFile\\(\\) expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/ShapeFile.php
-
-		-
-			message: "#^Parameter \\#1 \\$stream of function fclose expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/ShapeFile.php
-
 		-
 			message: "#^Parameter \\#1 \\$stream of function feof expects resource, resource\\|false given\\.$#"
-			count: 2
-			path: src/ShapeFile.php
-
-		-
-			message: "#^Parameter \\#1 \\$stream of function fread expects resource, resource\\|false given\\.$#"
 			count: 1
 			path: src/ShapeFile.php
 
-		-
-			message: "#^Parameter \\#1 \\$stream of function fwrite expects resource, resource\\|false given\\.$#"
-			count: 2
-			path: src/ShapeFile.php
-
 		-
 			message: "#^Parameter \\#1 \\$string of function substr expects string, string\\|false given\\.$#"
 			count: 6
@@ -60,26 +40,6 @@ parameters:
 			count: 1
 			path: src/ShapeFile.php
 
-		-
-			message: "#^Parameter \\#1 \\$dbase_identifier of function dbase_add_record expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/ShapeRecord.php
-
-		-
-			message: "#^Parameter \\#1 \\$dbase_identifier of function dbase_get_record_with_names expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/ShapeRecord.php
-
-		-
-			message: "#^Parameter \\#1 \\$dbase_identifier of function dbase_numrecords expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/ShapeRecord.php
-
-		-
-			message: "#^Parameter \\#1 \\$dbase_identifier of function dbase_replace_record expects resource, resource\\|false given\\.$#"
-			count: 1
-			path: src/ShapeRecord.php
-
 		-
 			message: "#^Parameter \\#2 \\$record_number of function dbase_get_record_with_names expects int, int\\|null given\\.$#"
 			count: 1

src/ShapeFile.php

@@ -304,6 +304,9 @@ public function getIndexFromDBFData(string $field, string $value): int
     private function loadDBFHeader(): array
     {
         $DBFFile = fopen($this->getFilename('.dbf'), 'r');
+        if ($DBFFile === false) {
+            return [];
+        }
 
         $result = [];
         $i = 1;
@@ -449,6 +452,10 @@ private function saveHeaders(): void
      */
     private function loadRecords(): bool
     {
+        if ($this->shpFile === false) {
+            return false;
+        }
+
         /* Need to start at offset 100 */
         while (! $this->eofSHP()) {
             $record = new ShapeRecord(-1);
@@ -475,7 +482,7 @@ private function loadRecords(): bool
     private function saveRecords(): void
     {
         $offset = 50;
-        if ($this->records === []) {
+        if ($this->records === [] || $this->shxFile === false || $this->shpFile === false) {
             return;
         }
 

src/ShapeRecord.php

@@ -40,7 +40,7 @@
 class ShapeRecord
 {
     /** @var resource */
-    private $shpFile = null;
+    private $shpFile;
 
     /** @var resource|false */
     private $dbfFile = false;
@@ -780,13 +780,17 @@ public function getContentLength(): ?int
 
     private function loadDBFData(): void
     {
+        if ($this->dbfFile === false) {
+            return;
+        }
+
         $this->dbfData = @dbase_get_record_with_names($this->dbfFile, $this->recordNumber);
         unset($this->dbfData['deleted']);
     }
 
     private function saveDBFData(): void
     {
-        if ($this->dbfData === []) {
+        if ($this->dbfData === [] || $this->dbfFile === false) {
             return;
         }