Skip to content

Housekeeping #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

Housekeeping #3

merged 1 commit into from
Jul 26, 2022

Conversation

ankurk91
Copy link
Contributor

Hi @mohammed-elhaouari

I was checking the source code of this awesome package, and found some minor issues

  • Fix many typos
  • Make readme.md more lean and easy to read with community standards
  • Remove unwanted doc block since type hints are sufficient
  • GitHub actions will run every month automatically via cron
  • Remove badges from readme footer, since it does not make sense
  • Remove un-used src/Exceptions/JsonEncodingException.php file
  • Move some *.md files to .github folder
  • Allow usage with composer 2.x (allow pest plugin to run)

You may want to update phpstan to v1.x

@mhdcodes
Copy link
Member

Thanks for your awesome contribution @ankurk91 , always appreciated.

@mhdcodes mhdcodes merged commit 2ba59e0 into phpjuice:main Jul 26, 2022
@mhdcodes mhdcodes mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdcodes mhdcodes mhdcodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankurk91 @mhdcodes