Skip to content

feat: add default timeouts to Guzzle Client #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022
Merged

feat: add default timeouts to Guzzle Client #2

merged 1 commit into from
Jul 26, 2022

Conversation

ankurk91
Copy link
Contributor

Hi @mohammed-elhaouari,

Thanks for this awesome package.

It is recommended to have timeouts to HTTP clients, recently Laravel has added timeouts to their HTTP client too.

Read more:

Thanks.

@ankurk91
Copy link
Contributor Author

@mohammed-elhaouari

GitHub actions are failing due to composer version 2

@mhdcodes
Copy link
Member

@ankurk91 I have merged #3 that should take care of allowing pest plugin. shouldn't this just run now ?

@ankurk91
Copy link
Contributor Author

Yes, you can re-run the actions, which should take care of composer 2

@mhdcodes
Copy link
Member

Apparently Github actions fails to update. it's still failing I'm gonna merge any way. Thanks for your great contribution @ankurk91

@mhdcodes mhdcodes merged commit 59fe151 into phpjuice:main Jul 26, 2022
@ankurk91
Copy link
Contributor Author

Thanks, it will pass after merging for sure.

Please tag a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants