Skip to content

Commit dde4c5b

Browse files
author
Greg Bowler
authored
maintenance: tidy up merges (#15)
1 parent 68a0d23 commit dde4c5b

File tree

4 files changed

+35
-30
lines changed

4 files changed

+35
-30
lines changed

composer.lock

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DataObjectBuilder.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ public function fromObject(
1111

1212
foreach($input as $key => $value) {
1313
if(is_object($value)) {
14-
$value = $this->fromObject($value);
14+
$value = $this->fromObject($value, $dataObjectClass);
1515
}
1616
elseif(is_array($value)) {
1717
if(is_int(key($value))) {
18-
array_walk($value, function(&$element) {
18+
array_walk($value, function(&$element)use($dataObjectClass) {
1919
if(is_object($element)) {
20-
$element = $this->fromObject($element);
20+
$element = $this->fromObject($element, $dataObjectClass);
2121
}
2222
});
2323
}
@@ -59,4 +59,4 @@ public function fromAssociativeArray(array $input):DataObject {
5959

6060
return $dataObject;
6161
}
62-
}
62+
}

test/phpunit/DataObjectBuilderTest.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
use Gt\DataObject\AssociativeArrayWithinObjectException;
55
use Gt\DataObject\DataObjectBuilder;
66
use Gt\DataObject\ObjectWithinAssociativeArrayException;
7+
use Gt\DataObject\Test\Helper\CustomDataObject;
78
use PHPUnit\Framework\TestCase;
89
use stdClass;
910

@@ -39,7 +40,7 @@ public function testFromObjectNested() {
3940
self::assertEquals("value4", $nestedOutput->getString("key4"));
4041
}
4142

42-
public function fromObjectNestedWithCustomClass() {
43+
public function testFromObjectNestedWithCustomClass() {
4344
$obj = new StdClass();
4445
$obj->key1 = "value1";
4546
$obj->key2 = "value2";
@@ -48,17 +49,14 @@ public function fromObjectNestedWithCustomClass() {
4849
$obj->nested->key3 = "value3";
4950
$obj->nested->key4 = "value4";
5051

51-
$myClass = new class extends StdClass {
52-
};
53-
5452
$sut = new DataObjectBuilder();
55-
$output = $sut->fromObject($obj, $myClass);
53+
$output = $sut->fromObject($obj, CustomDataObject::class);
5654

5755
$nestedOutput = $output->get("nested");
5856
$deepNestedOutput = $nestedOutput->getObject("deepNested");
5957
self::assertIsObject($nestedOutput);
60-
self::assertInstanceOf($myClass, $nestedOutput);
61-
self::assertInstanceOf($myClass, $deepNestedOutput);
58+
self::assertInstanceOf(CustomDataObject::class, $nestedOutput);
59+
self::assertInstanceOf(CustomDataObject::class, $deepNestedOutput);
6260
}
6361

6462
public function testFromObjectNestedArray() {
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?php
2+
namespace Gt\DataObject\Test\Helper;
3+
4+
use Gt\DataObject\DataObject;
5+
6+
class CustomDataObject extends DataObject {
7+
}

0 commit comments

Comments
 (0)