Test bool casting

Author: Greg Bowler

src/DataObject.php

@@ -29,19 +29,19 @@ public function get(string $name):mixed {
 	}
 
 	public function getString(string $name):?string {
-		return $this->getAsScalar($name, "string");
+		return $this->getAsType($name, "string");
 	}
 
 	public function getInt(string $name):?int {
-		return $this->getAsScalar($name, "int");
+		return $this->getAsType($name, "int");
 	}
 
 	public function getFloat(string $name):?float {
-		return $this->getAsScalar($name, "float");
+		return $this->getAsType($name, "float");
 	}
 
 	public function getBool(string $name):?bool {
-		// TODO: Implement getBool() method.
+		return $this->getAsType($name, "bool");
 	}
 
 	public function getDateTime(string $name):DateTimeInterface {
@@ -60,7 +60,7 @@ public function asObject(bool $nested = true):object {
 		return (object)$this->asArray($nested);
 	}
 
-	private function getAsScalar(
+	private function getAsType(
 		string $name,
 		string $type
 	):float|null|bool|int|string {
@@ -78,6 +78,8 @@ private function getAsScalar(
 			return (string)$value;
 		case "bool":
 			return (bool)$value;
+		default:
+			return new $type($value);
 		}
 	}
 }

test/phpunit/DataObjectTest.php

@@ -123,4 +123,33 @@ public function testGetFloatFromBool() {
 		self::assertSame(1.00, $sut->getFloat("this-is-true"));
 		self::assertSame(0.00, $sut->getFloat("this-is-false"));
 	}
+
+	public function testGetBoolFromString() {
+		$sut = (new DataObject())
+			->with("non-empty", "something")
+			->with("empty", "");
+
+		self::assertTrue($sut->getBool("non-empty"));
+		self::assertFalse($sut->getBool("empty"));
+	}
+
+	public function testGetBoolFromInt() {
+		$sut = (new DataObject())
+			->with("zero", 0)
+			->with("one", 1)
+			->with("two", 2);
+
+		self::assertFalse($sut->getBool("zero"));
+		self::assertTrue($sut->getBool("one"));
+		self::assertTrue($sut->getBool("two"));
+	}
+
+	public function testGetBoolFromFloat() {
+		$sut = (new DataObject())
+			->with("zero", 0.00)
+			->with("pi", 3.14159);
+
+		self::assertFalse($sut->getBool("zero"));
+		self::assertTrue($sut->getBool("pi"));
+	}
 }