IN conditions with empty arrays will always return false

Author: phpfui

src/PHPFUI/ORM/Condition.php

@@ -69,7 +69,16 @@ public function __toString() : string
 
 					if (\is_array($value) || $value instanceof \PHPFUI\ORM\Table)
 						{
-						$retVal .= '(' . \implode(',', \array_fill(0, \count($value), '?')) . ')';
+						$count = \count($value);
+
+						if ($count)
+							{
+							$retVal .= '(' . \implode(',', \array_fill(0, $count, '?')) . ')';
+							}
+						else	// in clause with empty set, can not be a match, return false
+							{
+							$retVal = 'FALSE';
+							}
 						}
 					elseif (null !== $value)
 						{

src/PHPFUI/ORM/Record.php

@@ -474,7 +474,7 @@ public function loadFromSQL(string $sql, array $input = []) : bool
 		// cast to correct values as ints, floats, etc are read in from PDO as strings
 		foreach (static::$fields as $field => $row)
 			{
-			if (null !== $this->current[$field]) // @phpstan-ignore-line
+			if (null !== $this->current[$field])
 				{
 				switch ($row[1])
 					{

src/PHPFUI/ORM/Schema/Field.php

@@ -8,6 +8,8 @@ class Field
 
 	public readonly ?string $defaultValue;
 
+	public readonly string $extra;
+
 	public readonly string $name;
 
 	public readonly bool $nullable;
@@ -16,8 +18,6 @@ class Field
 
 	public readonly string $type;
 
-	public readonly string $extra;
-
 	/**
 	 * @param array<string,mixed> $fields
 	 */
@@ -31,7 +31,8 @@ public function __construct(\PHPFUI\ORM\PDOInstance $pdo, array $fields, bool $a
 			$this->defaultValue = $fields['Default'];
 			$this->primaryKey = false;	// use indexes to find primary keys
 			$this->autoIncrement = \str_contains($fields['Extra'], 'auto_increment');
-			$this->extra = str_replace('auto_increment', '', $fields['Extra']);
+			$this->extra = \str_replace('auto_increment', '', $fields['Extra']);
+
 			return;
 			}
 		// SQLite