Better type validation for object assignments

Author: phpfui

Tests/DefinitionTest.php

@@ -65,6 +65,20 @@ public function testBadClassType() : void
 		$fixture->class = new \DateTime();
 		}
 
+	public function testClassAssignedInt() : void
+		{
+		$fixture = new \Tests\Fixtures\Type();
+		$this->expectException(\PHPFUI\ConstantContact\Exception\InvalidType::class);
+		$fixture->class = 1;
+		}
+
+	public function testClassAssignedString() : void
+		{
+		$fixture = new \Tests\Fixtures\Type();
+		$this->expectException(\PHPFUI\ConstantContact\Exception\InvalidType::class);
+		$fixture->class = 'class';
+		}
+
 	public function testBadEnum() : void
 		{
 		$fixture = new \Tests\Fixtures\Type();

src/ConstantContact/Definition/Base.php

@@ -172,10 +172,6 @@ public function __set(string $field, mixed $value)
 						}
 					}
 				}
-			elseif (! \is_object($value) && ! isset(self::$scalars[$expectedType]))
-				{
-				$value = new $expectedType($value);
-				}
 			elseif ($expectedType != $type)
 				{
 				throw new \PHPFUI\ConstantContact\Exception\InvalidType(static::class . "::{$actualField} is of type {$type} but should be type {$expectedType}");